Ready : v4. #102
Ready : v4. #102
Conversation
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 26.37% 25.96% -0.41%
==========================================
Files 26 28 +2
Lines 872 905 +33
Branches 153 160 +7
==========================================
+ Hits 230 235 +5
- Misses 642 668 +26
- Partials 0 2 +2
Continue to review full report at Codecov.
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
This is a large PR! I like to see it. Thank you very much! I tested it locally. It looks very nice! Geoguess is now playable on mobile devices like tablets and smartphones! I love this! Nevertheless, I would like to share points that I have noticed: NPM VulnerabiltiesNPM audit reports, that some vulnerabilities require our attention. One of them seems risky. NPM-Advisory-Codes are 1548, 1426, 1179, 1500, and 1523. I think, they just want to update us some libraries ;). After testing this PR we should look at this, before creating a new release. Unfortunately, I'm in the exam period and don't have time to look at it in detail. Maybe later! Small Design IssuesThe mobile design for Chromium-Browsers is working well! Unfortunately, other browsers like firefox still having design issues. So the map does not open on smartphone-view. On a tablet, I am unable to click on "guess", it is setting the marker under the guess-button onto the map. Nevertheless, it is a huge step forward! EDIT: On chromium-smartphone-view the size of the map can be higher, after clicking on the "expand"-button. Best regards and thank you very much! |
|
Thanks a lot @wlanowski For design issue : If you can add, screenshots it will be perfect. 🤩 |
See #104 |
No description provided.