Adding game mode settings to url #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 13, 2021 18:38
Added the parameter: modeSelected to the street-view route. in addition created validation preventing the game from starting with invalid mode
parameter: time is added to the street-view route, making the time of each round configurable via url. also adding validation preventing starting a game with the invalid parameter.
|
Deploy request for geoguess2 accepted. Accepted with commit ee76f25 https://app.netlify.com/sites/geoguess2/deploys/604d32fc8572ad000730c629 |
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
=======================================
Coverage 32.62% 32.62%
=======================================
Files 31 31
Lines 987 987
Branches 180 180
=======================================
Hits 322 322
Misses 661 661
Partials 4 4 Continue to review full report at Codecov.
|
Closed
|
@all-contributors please add @viniciusdof for code |
|
I've put up a pull request to add @viniciusdof! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the game mode settings to the url as described in the issue #97