Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fileIcon Manifest.json #142

Merged
merged 5 commits into from
Mar 19, 2021
Merged

fix: fileIcon Manifest.json #142

merged 5 commits into from
Mar 19, 2021

Conversation

BilelJegham
Copy link
Member

@BilelJegham BilelJegham commented Mar 15, 2021

Open with Geoguess
image

Enabling via chrome://flags #
To experiment with the File Handling API locally, without an origin trial token, enable the #file-handling-api flag in chrome://flags

Source: https://web.dev/file-handling/

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #142 (6156a08) into master (15edf7c) will increase coverage by 1.74%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   32.62%   34.36%   +1.74%     
==========================================
  Files          31       31              
  Lines         987     1001      +14     
  Branches      180      185       +5     
==========================================
+ Hits          322      344      +22     
+ Misses        661      653       -8     
  Partials        4        4              
Impacted Files Coverage Δ
src/components/home/DialogCustomMap.vue 29.62% <25.00%> (-0.11%) ⬇️
src/pages/StreetView.vue 15.81% <0.00%> (-0.46%) ⬇️
src/components/DialogSummary.vue 15.78% <0.00%> (+10.52%) ⬆️
src/components/Maps.vue 18.97% <0.00%> (+13.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15edf7c...6156a08. Read the comment docs.

@BilelJegham
Copy link
Member Author

Need loading screen when the file content load

@BilelJegham BilelJegham added this to the 0.5.1 milestone Mar 17, 2021
@BilelJegham BilelJegham merged commit 0752bbd into master Mar 19, 2021
@BilelJegham BilelJegham deleted the fix/fileIcon branch March 19, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant