Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/card room map #215

Merged
merged 21 commits into from
Sep 20, 2021
Merged

Feature/card room map #215

merged 21 commits into from
Sep 20, 2021

Conversation

BilelJegham
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 12, 2021

Codecov Report

Merging #215 (a7afa37) into master (aa9da60) will increase coverage by 0.07%.
The diff coverage is 44.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   40.44%   40.52%   +0.07%     
==========================================
  Files          38       43       +5     
  Lines        1219     1345     +126     
  Branches      237      257      +20     
==========================================
+ Hits          493      545      +52     
- Misses        700      775      +75     
+ Partials       26       25       -1     
Impacted Files Coverage Δ
src/components/dialogroom/card/CardRoomName.vue 22.22% <0.00%> (-17.78%) ⬇️
.../components/dialogroom/card/CardRoomPlayerName.vue 28.57% <ø> (ø)
...rc/components/dialogroom/card/CardRoomSettings.vue 15.78% <ø> (ø)
src/components/home/SearchBox.vue 50.00% <0.00%> (-19.57%) ⬇️
src/components/page/Footer.vue 0.00% <ø> (ø)
src/store/alertStore.js 0.00% <0.00%> (ø)
src/store/index.js 0.00% <ø> (ø)
src/store/settingsStore.js 20.89% <0.00%> (-0.32%) ⬇️
src/components/shared/SaveButton.vue 14.28% <14.28%> (ø)
src/store/homeStore.js 64.54% <21.87%> (-15.69%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9da60...a7afa37. Read the comment docs.

@BilelJegham BilelJegham marked this pull request as ready for review September 16, 2021 18:18
@BilelJegham BilelJegham linked an issue Sep 18, 2021 that may be closed by this pull request
@BilelJegham BilelJegham merged commit 72609d5 into master Sep 20, 2021
@BilelJegham BilelJegham deleted the feature/CardRoomMap branch September 20, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] UX: home feedback
1 participant