Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fixs rework #325

Merged
merged 15 commits into from
Nov 2, 2021
Merged

Feature/fixs rework #325

merged 15 commits into from
Nov 2, 2021

Conversation

BilelJegham
Copy link
Member

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

  1. Feat: Rework screen 'Result' : line dotted, + fix contrast color
  2. Fix: netlify file _redirect included in precache-manifest (cache bug)
  3. feat: i18n Alert update (rework service worker)

How Has This Been Tested?

  1. play game (multiplayer)
  2. Not error in console link to _redirect
  3. Add transalation and launch new build

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #325 (61b6e86) into master (6ca57cb) will increase coverage by 0.66%.
The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   41.48%   42.15%   +0.66%     
==========================================
  Files          43       43              
  Lines        1357     1376      +19     
  Branches      262      264       +2     
==========================================
+ Hits          563      580      +17     
- Misses        769      771       +2     
  Partials       25       25              
Impacted Files Coverage Δ
src/components/Maps.vue 19.44% <ø> (ø)
...rc/components/dialogroom/card/CardRoomSettings.vue 24.00% <ø> (ø)
src/components/map/MapAreas.vue 51.42% <ø> (ø)
src/components/page/Footer.vue 0.00% <ø> (ø)
src/pages/StreetView.vue 15.65% <ø> (ø)
src/App.vue 80.00% <80.00%> (+80.00%) ⬆️
...c/components/history/gameResult/HistoryMapArea.vue 50.00% <100.00%> (+16.66%) ⬆️
...omponents/history/gameResult/HistoryMapClassic.vue 33.33% <100.00%> (+33.33%) ⬆️
src/components/map/Map.vue 60.37% <100.00%> (+1.55%) ⬆️
src/constants.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca57cb...61b6e86. Read the comment docs.

@BilelJegham BilelJegham marked this pull request as ready for review November 2, 2021 20:52
@BilelJegham BilelJegham enabled auto-merge (squash) November 2, 2021 20:52
@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BilelJegham BilelJegham merged commit 2f28824 into master Nov 2, 2021
@BilelJegham BilelJegham deleted the feature/fixs-rework branch January 4, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant