Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #357 write_to_long exception firebase #358

Merged
merged 3 commits into from
Dec 29, 2021

Conversation

BilelJegham
Copy link
Member

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

Close #357

@sonarcloud
Copy link

sonarcloud bot commented Dec 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #358 (c921d82) into master (fba6c5b) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
+ Coverage   42.15%   42.18%   +0.03%     
==========================================
  Files          43       43              
  Lines        1376     1375       -1     
  Branches      264      263       -1     
==========================================
  Hits          580      580              
+ Misses        771      770       -1     
  Partials       25       25              
Impacted Files Coverage Δ
src/store/settingsStore.js 23.28% <ø> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cbbd6a...c921d82. Read the comment docs.

@BilelJegham BilelJegham merged commit 8c7b297 into master Dec 29, 2021
@BilelJegham BilelJegham deleted the fix/#357-multiplayers-india branch January 4, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Some countries doesn't work (multiplayer)
1 participant