Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/medals #377

Merged
merged 17 commits into from
Jan 31, 2022
Merged

Feature/medals #377

merged 17 commits into from
Jan 31, 2022

Conversation

BilelJegham
Copy link
Member

@BilelJegham BilelJegham commented Jan 23, 2022

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

Close #313

How Has This Been Tested?

Screenshots (if appropriate):

Medal Maps:
image
Medals Region
image

@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #377 (0d1f10b) into master (1ebe1b9) will increase coverage by 0.96%.
The diff coverage is 61.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   42.69%   43.65%   +0.96%     
==========================================
  Files          44       47       +3     
  Lines        1396     1498     +102     
  Branches      270      290      +20     
==========================================
+ Hits          596      654      +58     
- Misses        775      818      +43     
- Partials       25       26       +1     
Impacted Files Coverage Δ
src/components/DialogSummary.vue 18.75% <ø> (ø)
src/components/Maps.vue 19.44% <ø> (ø)
...omponents/history/gameResult/HistoryMapClassic.vue 33.33% <ø> (ø)
src/components/home/DialogCustomMap.vue 34.09% <ø> (+0.38%) ⬆️
src/components/home/MapsContainer.vue 89.47% <ø> (ø)
src/components/home/SearchBox.vue 50.00% <ø> (ø)
src/components/map/Map.vue 60.37% <ø> (ø)
src/components/map/MapAreas.vue 51.42% <ø> (ø)
src/components/page/ContentPage.vue 100.00% <ø> (ø)
src/components/page/Footer.vue 0.00% <ø> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ebe1b9...0d1f10b. Read the comment docs.

@BilelJegham BilelJegham marked this pull request as ready for review January 24, 2022 20:18
src/components/page/Header.vue Outdated Show resolved Hide resolved
src/utils/game/medals.js Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.3% 0.3% Duplication

@BilelJegham BilelJegham merged commit 26bf9b2 into master Jan 31, 2022
@BilelJegham BilelJegham deleted the feature/medals branch March 21, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Medal Mode for maps
1 participant