Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/optimize street view #425

Merged
merged 16 commits into from
May 18, 2022
Merged

Conversation

BilelJegham
Copy link
Member

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

How Has This Been Tested?

Screenshots (if appropriate):

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #425 (8c01718) into master (d821a2f) will increase coverage by 0.70%.
The diff coverage is 48.43%.

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
+ Coverage   43.59%   44.29%   +0.70%     
==========================================
  Files          47       51       +4     
  Lines        1498     1614     +116     
  Branches      290      312      +22     
==========================================
+ Hits          653      715      +62     
- Misses        819      867      +48     
- Partials       26       32       +6     
Impacted Files Coverage Δ
src/components/HeaderGame.vue 76.19% <ø> (-6.42%) ⬇️
...rc/components/dialogroom/card/CardRoomSettings.vue 24.00% <ø> (ø)
src/pages/MedalsPage.vue 14.28% <ø> (ø)
src/pages/StreetView.vue 18.33% <9.52%> (+2.68%) ⬆️
src/components/map/mixins/MapMixin.js 27.27% <20.00%> (+14.77%) ⬆️
src/plugins/StreetViewService.js 51.76% <51.76%> (ø)
src/utils/index.js 73.07% <81.81%> (-0.51%) ⬇️
src/components/Maps.vue 20.00% <100.00%> (+0.55%) ⬆️
src/components/dialogroom/card/CardRoomMap.vue 47.50% <100.00%> (+2.76%) ⬆️
src/store/settingsStore.js 24.16% <100.00%> (+1.03%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2efe2af...8c01718. Read the comment docs.

@BilelJegham BilelJegham marked this pull request as ready for review May 17, 2022 19:16
@sonarcloud
Copy link

sonarcloud bot commented May 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BilelJegham BilelJegham merged commit a399f27 into master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant