Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly Better TimePicker #486

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Conversation

EliteAsian123
Copy link
Contributor

@EliteAsian123 EliteAsian123 commented Jun 27, 2022

## Types of Changes

- [ ] Bug fix (non-breaking change that fixes an issue)
- [x] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Changes

  • Bug fix: Added padding to the seconds so it displays 00 instead of just 0
  • Adjustment: The time updates while the slider is being moved instead of after it has moved
  • Adjustment: Slider ticks

Screenshots (if appropriate):

Before:

Before

After:

After

@netlify
Copy link

netlify bot commented Jun 27, 2022

‼️ Deploy request for geoguess2 rejected.

Name Link
🔨 Latest commit 31cd3c3

Copy link
Member

@BilelJegham BilelJegham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for you contribution.

I write a small feedback.

Best regards,
Bilel

src/components/shared/TimePicker.vue Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #486 (3a8b6b6) into master (34aec64) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #486   +/-   ##
=======================================
  Coverage   55.81%   55.81%           
=======================================
  Files          46       46           
  Lines         774      774           
  Branches      158      158           
=======================================
  Hits          432      432           
  Misses        310      310           
  Partials       32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34aec64...3a8b6b6. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@BilelJegham BilelJegham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

Thanks @EliteAsian123

@BilelJegham BilelJegham merged commit 71b12f7 into GeoGuess:master Jun 30, 2022
@BilelJegham
Copy link
Member

@all-contributors please add @EliteAsian123 for code

@allcontributors
Copy link
Contributor

@BilelJegham

I've put up a pull request to add @EliteAsian123! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants