Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage : Maps list #52

Merged
merged 18 commits into from
Nov 8, 2020
Merged

Homepage : Maps list #52

merged 18 commits into from
Nov 8, 2020

Conversation

BilelJegham
Copy link
Member

No description provided.

@cypress
Copy link

cypress bot commented Nov 5, 2020



Test summary

2 0 0 0


Run details

Project Geoguess
Status Passed
Commit 8d45a17 ℹ️
Started Nov 6, 2020 5:18 PM
Ended Nov 6, 2020 5:19 PM
Duration 00:38 💡
OS Linux Ubuntu - 16.04
Browser Chrome 86

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@BilelJegham BilelJegham linked an issue Nov 5, 2020 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented Nov 5, 2020

Codecov Report

Merging #52 into master will increase coverage by 9.11%.
The diff coverage is 78.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   11.82%   20.93%   +9.11%     
==========================================
  Files          16       21       +5     
  Lines         626      707      +81     
  Branches      107      116       +9     
==========================================
+ Hits           74      148      +74     
- Misses        552      559       +7     
Impacted Files Coverage Δ
src/store/index.js 0.00% <0.00%> (ø)
src/components/widgets/dialog/DialogRoom.vue 12.76% <9.09%> (-0.49%) ⬇️
src/components/DialogCustomMap.vue 5.35% <10.00%> (+0.87%) ⬆️
src/components/home/SearchBox.vue 83.33% <50.00%> (-16.67%) ⬇️
src/store/homeStore.js 94.20% <94.20%> (ø)
src/components/home/maps/MapCard.vue 100.00% <100.00%> (ø)
src/components/home/maps/MapDialog.vue 100.00% <100.00%> (ø)
src/pages/Home.vue 100.00% <100.00%> (ø)
src/store/mutation-types.js 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eecf7c...fa3ee20. Read the comment docs.

@BilelJegham BilelJegham changed the title Feature/#34 share map Homepage : Maps list Nov 6, 2020
@BilelJegham BilelJegham marked this pull request as ready for review November 6, 2020 18:16
Copy link
Member

@simonrousseau simonrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature !
And the testing setup is really well done.

@BilelJegham BilelJegham merged commit b4ef456 into master Nov 8, 2020
@BilelJegham BilelJegham deleted the feature/#34-ShareMap branch November 13, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find a solution to share map
3 participants