Update to Vite #665
Merged
Update to Vite #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for geoguess2 pending review.Visit the deploys page to approve it
|
Troplo
suggested changes
Aug 5, 2023
BilelJegham
reviewed
Aug 5, 2023
Co-authored-by: Bilel Jegham <BilelJegham@users.noreply.github.com>
Merge branch 'master' of https://github.com/GeoGuess/GeoGuess into Ge…
|
Stryker and Cypress are tested and running, I also merged the latest commits from GeoGuess/GeoGuess |
BilelJegham
reviewed
Aug 11, 2023
BilelJegham
reviewed
Aug 11, 2023
BilelJegham
reviewed
Aug 11, 2023
Co-authored-by: Bilel Jegham <BilelJegham@users.noreply.github.com>
Co-authored-by: Bilel Jegham <BilelJegham@users.noreply.github.com>
|
Nevermind I think I figured it out, this appears to work? await wrapper.setData({ search: 'Toulouse' });
await wrapper.vm.$nextTick();
expect(wrapper.vm.axios.get).toBeCalledWith('https://photon.komoot.io/api/?q=Toulouse');
await wrapper.vm.$nextTick();
expect(wrapper.exists('#search-input')); |
Troplo
approved these changes
Sep 25, 2023
BilelJegham
reviewed
Oct 3, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
Can we get this merged so we can work on Vue 3 |
BilelJegham
approved these changes
Nov 13, 2023
|
Some issues before merge, I'm making some adjustments :
|
ElectricS01
commented
Nov 13, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #665 +/- ##
===========================================
+ Coverage 52.12% 81.84% +29.71%
===========================================
Files 53 54 +1
Lines 752 11223 +10471
Branches 209 324 +115
===========================================
+ Hits 392 9185 +8793
- Misses 328 1999 +1671
- Partials 32 39 +7 ☔ View full report in Codecov by Sentry. |
|
|
|
Running |
Troplo
approved these changes
Jan 18, 2024
BilelJegham
added a commit
that referenced
this pull request
Apr 12, 2024
* Doesn't load past home page * Loads slightly more on home page * Loads a bit more, buttons don't work * Working * Refactor imports * Fully working * Removed Jest as it is not Vite compatible * Update src/lang/index.js Co-authored-by: Bilel Jegham <BilelJegham@users.noreply.github.com> * Reverse trailing commas and version number * Everything but Cypress is working * Merge branch 'master' of https://github.com/GeoGuess/GeoGuess into GeoGuess-master * Fix eslint * Update package.json Co-authored-by: Bilel Jegham <BilelJegham@users.noreply.github.com> * Update package.json Co-authored-by: Bilel Jegham <BilelJegham@users.noreply.github.com> * Vitest not working yet * Vitest working a bit more * Patched jest-google-maps-mock * Update vite.config.js * Vitest almost working * Fixed stryker * Add @ imports back * Forgot some * Update CardRoomMap.spec.js * Update /store/index.js * Merge * fix: package * fix: lint * fix: add coverage test * Fix patch package failure * Fix ESLint with Vitest * Update snapshot? --------- Co-authored-by: Bilel Jegham <BilelJegham@users.noreply.github.com> Co-authored-by: BilelJegham <contact.bileljegham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of Changes
Description
Updated GeoGuess to use Vite instead of the slow and outdated Vue CLI, this has taken build times from 40-50s down to about 1s.
Main changes
VITE_APP_instead ofVUE_APP_What's broken
How Has This Been Tested?
Vite has been tested in production, with a built dev server and netlify, some options might not be working.
Sample site with Vite here