Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve color of crowns in DialogSummary #94

Merged
merged 2 commits into from
Feb 1, 2021
Merged

improve color of crowns in DialogSummary #94

merged 2 commits into from
Feb 1, 2021

Conversation

wlanowski
Copy link
Contributor

The colors of the crown shown in DialogSummary are not beautiful. Especially the silver crown is nearly unvisible.

@netlify
Copy link

netlify bot commented Jan 30, 2021

Deploy request for geoguess2 rejected.

Rejected with commit 8ef84c8

https://docs.netlify.com/configure-builds/environment-variables/#sensitive-variable-policy

@codecov-io
Copy link

Codecov Report

Merging #94 (9b5bbdd) into master (867c4e0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   26.37%   26.37%           
=======================================
  Files          26       26           
  Lines         872      872           
  Branches      153      153           
=======================================
  Hits          230      230           
  Misses        642      642           
Impacted Files Coverage Δ
src/components/DialogSummary.vue 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867c4e0...9b5bbdd. Read the comment docs.

Copy link
Member

@BilelJegham BilelJegham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

__________ PR change ___________________________________________________________ actual __________

We lost contrast in the gold icon, no?

@wlanowski
Copy link
Contributor Author

you are right. Maybe this "gold" is bether for us.
newgold

@BilelJegham BilelJegham merged commit e04baef into GeoGuess:master Feb 1, 2021
@wlanowski wlanowski deleted the branch1 branch February 2, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants