Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate that 3D geometries are not supported. #26

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

stijnherreman
Copy link
Contributor

No description provided.

Copy link
Member

@xfischer xfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stijnherreman. Sounds as if it couldn't be fixed. What's your thoughts ?

@xfischer xfischer merged commit 5d13b5b into GeoJSON-Net:master Jun 2, 2020
@stijnherreman
Copy link
Contributor Author

Hi @xfischer, it should be possible to fix this yes, IPosition supports it at least. I might submit a PR, haven't decided yet. I considered migrating this part of our code to NTS but that also has a few blockers for our scenario, so I need to evaluate which path to continue on.

@xfischer
Copy link
Member

xfischer commented Jun 2, 2020

And WKB supports it too : https://en.wikipedia.org/wiki/Well-known_text_representation_of_geometry

@alvaromongon you were the original contributor of Wkb for GeoJson.net. Any chance you can add support of Z coordinates ?

@stijnherreman OK, feel free to submit an PR if you made things work in this repo.
If you're stuck I may try to help if I'm not too busy with my other projects.

@stijnherreman
Copy link
Contributor Author

Indeed, it's a matter of adding support for types 1001-1007. The mentioned exception is intentionally thrown here:

throw new Exception("Unsupported type");

@xfischer
Copy link
Member

xfischer commented Jun 2, 2020

Plus the encoder/decoder part. I don't think it should be too hard. I wish I had more time to do this, but not at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants