Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow dropdowns in basic header #167

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

CallumNZ
Copy link
Contributor

@CallumNZ CallumNZ commented May 9, 2024

Proposed Changes

Reference: https://github.com/GeoNet/tickets/issues/11365

Changes proposed in this pull request:

  • allow dropdowns in basic header

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

@CallumNZ CallumNZ requested a review from bpeng May 9, 2024 01:34
BREAKING CHANGE: header basic config links field now called items
Copy link
Contributor

@bpeng bpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@sue-h-gns sue-h-gns merged commit b295103 into main May 9, 2024
5 checks passed
@CallumNZ CallumNZ deleted the basicHeaderDropdown branch May 9, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants