Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for seiscomp3-schema/0.6, 0.12 #168

Merged
merged 1 commit into from
May 14, 2024
Merged

add support for seiscomp3-schema/0.6, 0.12 #168

merged 1 commit into from
May 14, 2024

Conversation

bpeng
Copy link
Contributor

@bpeng bpeng commented May 13, 2024

Proposed Changes

Refer https://github.com/GeoNet/tickets/issues/15259

Changes proposed in this pull request:

  • update for seiscomp3-schema/0.6, 0.12
  • As there is currently no seiscompml 0.12 file, a seiscompml 0.13 file is used (with changing the version number, and validated ) for testing

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

@bpeng bpeng requested a review from junghao May 13, 2024 01:25
Copy link
Contributor

@junghao junghao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sue-h-gns sue-h-gns merged commit 1a968ac into main May 14, 2024
5 checks passed
@sue-h-gns sue-h-gns deleted the sc6 branch May 14, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants