Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map json data element does not contain map sublement when creating a map #33

Closed
emilianocastaneda opened this issue Sep 19, 2020 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@emilianocastaneda
Copy link

We found that on django_mapstore_adapter\mapstore2_adapter\plugins\serializers.py when creating a map (executing perform_create) the map subelement of the data element is not stored correctly:

Line 313:
self.set_geonode_map(caller, serializer, map_obj, _data, _attributes) -> this makes a pop of subelement map of element _data so its not anymore on _data element

Line 317:
GeoNodeSerializer.update_data(serializer, _data) -> this saves the map data element without the map subelement as it is no longer present

On the other hand when updating the map (executing perform_update, same file) , as the two statements are executed on inverted order, this works, and saves the map subelement correctly

@afabiani afabiani self-assigned this Oct 13, 2020
afabiani pushed a commit that referenced this issue Oct 13, 2020
…n creating a map

(cherry picked from commit 35b609b)
@afabiani afabiani added the bug Something isn't working label Oct 13, 2020
@afabiani afabiani added this to the 2.4.0.8 milestone Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants