-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1603: Fix - Download button visibility with url and view only perms #1606
Conversation
if ((isEmpty(_resource?.download_urls) && !_resource?.perms?.includes('download_resourcebase')) || (!isButton && isNotAjaxSafe)) { | ||
if ((isEmpty(_resource?.download_urls) && !_resource?.perms?.includes('download_resourcebase')) | ||
|| !_resource?.perms?.includes('download_resourcebase') | ||
|| (!isButton && isNotAjaxSafe) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we showing a different icon in case of isNotAjaxSafe @dsuren1? I think it should still be shown as download even if it's not handled over ajax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@giohappy Yes, currently (AJAX safe) and (AJAX not safe)
I think it should still be shown as download even if it's not handled over ajax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
* #1596 - Catalog page path configuration (#1597) * [create-pull-request] automated change (#1599) Co-authored-by: allyoucanmap <allyoucanmap@users.noreply.github.com> * Fix ajax safe download button render (#1601) * #1598: Facet fixes on different filter type (#1600) * [create-pull-request] automated change (#1602) Co-authored-by: allyoucanmap <allyoucanmap@users.noreply.github.com> * #1594 - Enhance filter panel and accordion with configurable options (#1595) * [create-pull-request] automated change (#1605) Co-authored-by: allyoucanmap <allyoucanmap@users.noreply.github.com> * #1607: Tabs component enhancement (#1608) * [create-pull-request] automated change (#1609) Co-authored-by: allyoucanmap <allyoucanmap@users.noreply.github.com> * #1603: Fix - Download button visibility with url and view only perms (#1606) * [create-pull-request] automated change (#1610) Co-authored-by: allyoucanmap <allyoucanmap@users.noreply.github.com> * Fixes #1612 - Implement Django admin management for MS Search services (#1613) * Implement django admin management search services * Implement django admin management search services * Implement django admin management search services * Implement django admin management search services * Implement django admin management search services * Implement django admin management search services * Fix typo * Improvements to model help texts * fixed cache name and key * Improvements to hel texts --------- Co-authored-by: Giovanni Allegri <giovanni.allegri@gmail.com> Co-authored-by: G. Allegri <giohappy@gmail.com> --------- Co-authored-by: Suren <dsuren1@gmail.com> Co-authored-by: geosolutions-pr-generator[bot] <87376048+geosolutions-pr-generator[bot]@users.noreply.github.com> Co-authored-by: allyoucanmap <allyoucanmap@users.noreply.github.com> Co-authored-by: mattiagiupponi <51856725+mattiagiupponi@users.noreply.github.com>
Description
This PR fixes the download button visibility with
download_urls
present and withview
only permsIssue