Fix certbot staging certificate generation

[frafra]

Fix #203.

[lpasquali]

@frafra, many thanks for this PR

I think that a better foreseeing fix might be try to remove --staging in staging and the whole --server option for both prod and staging and use --dry-run option in certbot for staging certificates. This way we will not depend anymore on ACME host names changes (see https://letsencrypt.org/docs/staging-environment/)

[frafra]

@lpasquali Ok! I would then suggest renaming "STAGING" to "DRYRUN" to avoid confusion (as different certificates will be served over HTTPS).

[lpasquali]

@lpasquali Ok! I would then suggest renaming "STAGING" to "DRYRUN" to avoid confusion (as different certificates will be served over HTTPS).

well it is still staging stating at the current doc I pasted, the option --dry-run uses staging ACME environment, we'd just need to update to a simpler configuration the certbot commands and since --dryrun does stating certs, I'm unsure this would be a real benefit in avoiding confusion

[frafra]

@lpasquali Ok! I would then suggest renaming "STAGING" to "DRYRUN" to avoid confusion (as different certificates will be served over HTTPS).

well it is still staging stating at the current doc I pasted, the option --dry-run uses staging ACME environment, we'd just need to update to a simpler configuration the certbot commands and since --dryrun does stating certs, I'm unsure this would be a real benefit in avoiding confusion

--dry-run Perform a test run of the client, obtaining test
(invalid) certificates but not saving them to disk.

-- https://certbot.eff.org/docs/using.html?highlight=--dry-run#certbot-command-line-options

It is my understanding that a GeoNode instance with set to "STAGING" will not get SSL certificates at all then, so it would rely on local self-signed certificates if available. That would break many browsers, probably.

[lpasquali]

@lpasquali Ok! I would then suggest renaming "STAGING" to "DRYRUN" to avoid confusion (as different certificates will be served over HTTPS).

well it is still staging stating at the current doc I pasted, the option --dry-run uses staging ACME environment, we'd just need to update to a simpler configuration the certbot commands and since --dryrun does stating certs, I'm unsure this would be a real benefit in avoiding confusion

--dry-run Perform a test run of the client, obtaining test
(invalid) certificates but not saving them to disk.

-- https://certbot.eff.org/docs/using.html?highlight=--dry-run#certbot-command-line-options

It is my understanding that a GeoNode instance with set to "STAGING" will not get SSL certificates at all then, so it would rely on local self-signed certificates if available. That would break many browsers, probably.

@frafra I beg your pardon, I wanted to mean "--test-cert" (--staging is left for backward compatibility) , "--dry-run" is not to be used in our case.

[frafra]

@frafra I beg your pardon, I wanted to mean "--test-cert" (--staging is left for backward compatibility) , "--dry-run" is not to be used in our case.

Ok! Great then :)
I updated my branch.

[afabiani]

@lpasquali if it's ok with you we can merge then

[lpasquali]

@lpasquali if it's ok with you we can merge then

changes approved @afabiani