Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy forms and views for layer upload, replace and append operations #12046

Closed
giohappy opened this issue Mar 14, 2024 · 0 comments · Fixed by #12073
Closed

Remove legacy forms and views for layer upload, replace and append operations #12046

giohappy opened this issue Mar 14, 2024 · 0 comments · Fixed by #12073
Assignees
Milestone

Comments

@giohappy
Copy link
Contributor

giohappy commented Mar 14, 2024

Datasets uploads:

  • Legacy upload views have been replaced by the new API
  • The legacy upload UI is not exposed anymore
  • Append and Replace actions are not exposed anymore and the existing views do not play well with the new importer architectures. They will be implemented again according to the new models
  • Legacy code is not maintained and can become the source of vulnerabilities

SLD and XML metadata files:

  • the current forms have a list of issues. They are basically broken on master branch, since they use legacy code in the backend that has been dropped meanwhile. They should be adapted to the new APIs, but it isn't probably worth it.

For the reasons above the following parts of code will be removed from core:

dataset_upload (including urls)
	-> dataset_upload_metadata 
		-> NewLayerUploadForm
			-> LayerUploadForm
				-> validate_uploaded_files
	-> dataset_style_upload
		-> NewLayerUploadForm
			-> LayerUploadForm
				-> validate_uploaded_files
		
dataset_append (including dataset_append.html template and urls)
	-> dataset_append_replace_view
		-> LayerUploadForm
			-> validate_uploaded_files

dataset_replace (including dataset_replace.html template and urls)
	-> dataset_append_replace_view
		-> LayerUploadForm
			-> validate_uploaded_files

Tests will be adapted acordingly.

@mattiagiupponi mattiagiupponi modified the milestones: 4.4.0, 4.3.0 Mar 21, 2024
giohappy pushed a commit that referenced this issue Mar 21, 2024
…e and append (#12073)

* [Fixes #12046] Remove legacy forms and views for layer upload, replace and append

* [Fixes #12046] Remove legacy forms and views for layer upload, replace and append

* [Fixes #12046] Remove legacy forms and views for layer upload, replace and append

* [Fixes #12046] Remove legacy forms and views for layer upload, replace and append

* [Fixes #12046] Remove legacy forms and views for layer upload, replace and append
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants