Upload Layer: the check on default style is weak. Use geometry type instead

[afabiani]

When creating a default sld for a new uploaded layer, the check on default style is weak and also prone to failures.

It would be better to check for geometry type instead.

[capooti]

thanks, this will be really useful.
Though best way would be to do it by adding a geometry_type in layer as per #3007

[afabiani]

Yes, we can reuse the code of #3035 in order to add geom type to the model. Best Regards, Alessio Fabiani. == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Alessio Fabiani @alfa7691 github <https://github.com/afabiani?tab=overview> Founder/Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 331 6233686 http://www.geo-solutions.it http://twitter.com/geosolutions_it

…

------------------------------------------------------- *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

---------------------------------------------------------------------

On Wed, May 10, 2017 at 10:31 PM, Paolo Corti ***@***.***> wrote: thanks, this will be really useful. Though best way would be to do it adding a geometry_type in layer as per #3007 <#3007> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3035 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABOARfHO0dtpZxRFoTRrlVl09G59fFcXks5r4h6YgaJpZM4NW8lx> .

[capooti]

In my opinion, we should use gdal to detect the geometry type of the shapefile in the python code as soon as the shapefile is uploaded rather than relying on an http request. Specially if the layer is registred in GeoServer asynchronously with celery