Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Legend displayed in the layer detail page #6596

Closed
afabiani opened this issue Oct 30, 2020 · 0 comments
Closed

Incorrect Legend displayed in the layer detail page #6596

afabiani opened this issue Oct 30, 2020 · 0 comments
Assignees
Labels
minor A low priority issue which might affect only some users and /or not the main functionality
Projects
Milestone

Comments

@afabiani
Copy link
Member

The default style appears to be associated correctly (styles section in sidebar shows it), but the shown legend is wrong.

image

68747470733a2f2f6174746163686d656e742e66726573686465736b2e636f6d2f696e6c696e652f6174746163686d656e743f746f6b656e3d65794a30655841694f694a4b563151694c434a68624763694

The fix is not trivial. That layer makes use of styles defined on a workspace different from "geonode" (i.e. "mps").

We will need to refactor a bit the style_maage code and legend rendering on the layer_details page in order to be able parsing the styles from other workspaces than the default one.

Quick fix: move GeoServer Styles to the "geonode" workspace.

@afabiani afabiani added the minor A low priority issue which might affect only some users and /or not the main functionality label Oct 30, 2020
@afabiani afabiani added this to the 3.1 milestone Oct 30, 2020
@afabiani afabiani self-assigned this Oct 30, 2020
@afabiani afabiani added this to To do in 3.1 Release via automation Oct 30, 2020
afabiani pushed a commit that referenced this issue Oct 30, 2020
afabiani pushed a commit that referenced this issue Oct 31, 2020
afabiani pushed a commit that referenced this issue Nov 3, 2020
[Fixes #6596] Incorrect Legend displayed in the layer detail page
3.1 Release automation moved this from To do to Done Nov 3, 2020
afabiani pushed a commit that referenced this issue Nov 3, 2020
[Fixes #6596] Incorrect Legend displayed in the layer detail page

(cherry picked from commit fe0ceee)

# Conflicts:
#	geonode/tests/integration.py
afabiani pushed a commit that referenced this issue Dec 10, 2020
…ble entities into the framework (#6713)

* [Hardening] - Recenet Activity List for Documents error when actor is None

* [Frontend] Monitoring: Bump "node-sass" to version 4.14.1

* [Frontend] Bump jquery to version 3.5.1

* [Fixes: #6519] Bump jquery to 3.5.1 (#6526)

(cherry picked from commit e532813)

# Conflicts:
#	geonode/static/lib/css/assets.min.css
#	geonode/static/lib/css/bootstrap-select.css
#	geonode/static/lib/css/bootstrap-table.css
#	geonode/static/lib/js/assets.min.js
#	geonode/static/lib/js/bootstrap-select.js
#	geonode/static/lib/js/bootstrap-table.js
#	geonode/static/lib/js/leaflet-plugins.min.js
#	geonode/static/lib/js/leaflet.js
#	geonode/static/lib/js/moment-timezone-with-data.js
#	geonode/static/lib/js/underscore.js

* Merge branch 'master' of https://github.com/GeoNode/geonode into rest_api_v2_proof_of_concept

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.

* [Hardening] Re-create the map thumbnail only if it is missing

* Fixes error with GDAL 3.0.4 due to a breaking change on GDAL (https://code.djangoproject.com/ticket/30645)

* Fixes error with GDAL 3.0.4 due to a breaking change on GDAL (https://code.djangoproject.com/ticket/30645)

* - Introducing the concept of "GeoNode App" Resource Base

* [GeoApps] Add "Create new" Button to the apps list page

* [GeoApps] Hooking Resources List pages

* [GeoApps] Hooking GeoApp List page

* [GeoApps] Hooking GeoApp rest v2 API serializers fixes

* [GeoApps] Fix resourcebase_api polymorphic ctype filter

* [GeoApps] REST API v2 "geostories" endpoints optimizations

* [REST APIs V2] Make use of the new "bbox_polygon" field based on GeoDjango

* [Fixes RemoteServices bbox parse] Merge branch 'search-by-extent' of https://github.com/mtnorthcott/geonode

* [Fix migrations] Merge branch 'search-by-extent' of https://github.com/mtnorthcott/geonode

* [Fix migrations] Merge branch 'search-by-extent' of https://github.com/mtnorthcott/geonode

* [GeoApps] Adding "geoapp_edit" page

* [GeoApps] Adding "geoapp_edit" page context

* [GeoApps] Adding security info (access_token, user, ...) to the page context

* [GeoApps] Adding client endpoints

* [GeoApps] Missing "post_save" signal

* [GeoApps] Finalize GeoApp resources management

* Fix "bbox_to_projection" coords order

* Fix 'bbox_to_projection' coords order

* Fix "bbox_to_projection" coords order

(cherry picked from commit 72d6c1e)

* Fix "bbox_to_projection" coords order: check GDAL version >= 3.0.4

* Include missing 'mapstore2_adapter.geoapps' app to default INSTALLED_APPS

* Include mapstore client branch dependencies into requirements

* Revert security commit on branch

* Minor review of the current advanced resource workflow implementation #6551

* Minor review of the current advanced resource workflow implementation #6551

* Fix tests on Travis

* Fix tests on Travis

* Fix tests on Travis

* Fix tests on Travis

* Fix tests on Travis

(cherry picked from commit c7f651c)

# Conflicts:
#	geonode/layers/tests.py

* Fix logical errors on approval workflow

* Fix logical errors on approval workflow

(cherry picked from commit 7a3d5d0)

* Fix tests on Travis

* Cleanup "app_embed" template

* Advanced workflow: remove change_permissions to the owner if not a manager

* Advanced workflow: remove change_permissions to the owner if not a manager

(cherry picked from commit 9a1552a)

* Fix app_embed template

* Advanced workflow: remove change_permissions to the owner if not a manager

* Advanced workflow: remove change_permissions to the owner if not a manager

* Advanced workflow: remove change_permissions to the owner if not a manager

(cherry picked from commit f23096c)

* Advanced workflow: remove change_permissions to the owner if not a manager

(cherry picked from commit bfe51a7)

* Advanced workflow: remove change_permissions to the owner if not a manager

* Advanced workflow: remove change_permissions to the owner if not a manager

(cherry picked from commit d9ec566)

* Advanced workflow: filter actions stream returned to the users accordingly to their perms

* Advanced workflow: filter actions stream returned to the users accordingly to their perms

(cherry picked from commit 7f51346)

* Advanced workflow: filter actions stream returned to the users accordingly to their perms

* Add new settings from django-allauth 0.43.0

* Advanced workflow: filter actions stream returned to the users accordingly to their perms

(cherry picked from commit e2522fd)

* Add new settings from django-allauth 0.43.0

(cherry picked from commit 00f4be1)

* Code styling alerts: remove unnecessary pass

* Refreshing static libs

* Refreshing static libs

* Code styling alerts: remove unnecessary pass

(cherry picked from commit 0676f6e)

* Refreshing static libs

(cherry picked from commit f27d0df)

* Refreshing static libs

(cherry picked from commit 5b166bc)

* Advanced Workflow: Make sure the APIs counters are coherent with the visible resources

* Advanced Workflow: Make sure the APIs counters are coherent with the visible resources

(cherry picked from commit 1855d74)

* fix english/italian translations (#6563)

* fix english/italian translations (#6563)

* Advanced Workflow: fix "request editing" action when published

* Advanced Workflow: fix "request editing" action when published -> send messages to group managers too

* Advanced Workflow: fix "request editing" action when published

(cherry picked from commit 1041b12)

* Advanced Workflow: fix "request editing" action when published -> send messages to group managers too

(cherry picked from commit 5c93ef3)

* Fix test on travis

* fix english/italian translations (#6563)

* fix english/italian translations (#6563)

* fix english/italian translations (#6563)

* Avoid override User settings on "set_attributes_from_geoserver"

* - Docs links to 3.x branch

* Improve Celery Async Tasks configuration

(cherry picked from commit 50e208a)

* Improve Celery Async Tasks configuration

(cherry picked from commit d5150e8)

* Improve Celery Async Tasks configuration

(cherry picked from commit 50e208a)

* - Replace build.geo-solutions.it with www.dropbox.com

(cherry picked from commit 882e3e5)
(cherry picked from commit 7b970f8)

* [Security] Hardening Advanced Workflow resources visibility

(cherry picked from commit 2103f13)
(cherry picked from commit 025c82e)

* [Hardening] Removing redundant and replacement of instance abstract from GeoServer

* Bump drf-yasg from 1.17.1 to 1.20.0

* [Hardening] Fixes: db connection closed and worker hangs with celery 4.2+ celery/celery#4878

* [Hardening] Optimizing celery tasks settings

* [Hardening] Optimizing celery tasks settings

* - Documents REST v2 APIs

* [Fixes #6596] Incorrect Legend displayed in the layer detail page

(cherry picked from commit 0aa6902)

* [Fixes #6596] Incorrect Legend displayed in the layer detail page

(cherry picked from commit 0aa6902)

* - Update travis dist to '20.04 focal'

* - Fix geolimits panel translations

* - Filter Comments on Recent Activities accordingly to the user's perms

* [Hardening] Remove wrong class initializer

* [Hardening] LGTM warning fixes

* [CI Optimizations] - Continuous integration builders: CircleCI config based on "spcgeonode" docker-compose

(cherry picked from commit 7f091a7)

* - Enable "memcached" plugins for monitoring

* - Extend "documents" to accept and render video, audio and more image formats

 - Add "attribution" field to ResourceBase model

* - Generating documents thumbnails for video and audio mime types

(cherry picked from commit d1f4251)
(cherry picked from commit 5c89762)

* - Merge with master branch

* - Generating documents thumbnails for video and audio mime types

(cherry picked from commit 197c7ab)

* - Fixing doc image thumn generation

* - Updating translations

* - expose documents 'href' from REST serializer API endpoint

* [Hardening] - expose **secured** documents 'href' from REST serializer API endpoint

* [Hardening] - generate **secured** thumbnail for uploaded images

* - Restore missing list key on GXP_PTYPES enumeration

(cherry picked from commit 2352613)

* [FIX #6626] add tinymce editor to resource text areas

(cherry picked from commit 45bb0dc)

* [FIX #6626] add tinymce editor to resource text areas

(cherry picked from commit 45bb0dc)

* [Hardening] Correctly manage "_resolve_object" exception as Django error templates

(cherry picked from commit 017d885)

# Conflicts:
#	geonode/views.py

* - Remove wrong migration

* [Hardening] Using "apply_async" instead of "delay" for async signals calls

* [Hardening] Avoid exit prematurely from geoserver cascading delete signal

* Fix travis tests

* [Fixes #5779] Data edition permissions set in GeoNode for a layer are not applied on the WFS

(cherry picked from commit 9e4e839)

* - Cleaning up wrong migrations

* [Performance] - Improve Style editing requests callbacks

* [Performance] - Transform "geoserver_post_save_layers" to an asynchronous task

* [Performance] - Improve Style editing requests callbacks

* [Optimization] Improve 'navbar' content reposition script

* [Performance] - Transform "geoserver_post_save_layers" to an asynchronous task

* [Performance] - Improve Style editing requests callbacks

* FIXES[#6653] Mail notifications for private datasets are public

* - exclude query optimization

* [Performance] Dinamically loading the list of users geo-limits

(cherry picked from commit c54cc61)
(cherry picked from commit 756c1aa)

* [Fixes: #6640] Style Tag outside of html (#6657)

* [Minor Layout Issue] - Missing title on "map list" page

(cherry picked from commit 971e65f)

* added Document Creation Fallback, fixed exclude_user_ids.append()

* - Correct "geoapps" notification types

* - Fix remaining issues: 1. Layer create does no send "title" before sending notifications - 2. Doc created does not set "permissions" before sending notifications

* Typo: _QUEUE_ALL_FLAG

* Typo: _QUEUE_ALL_FLAG

(cherry picked from commit 8d9118f)

* - Fix asynchronous notification engine task

* - Fix asynchronous notification engine task

(cherry picked from commit 79274eb)

* - Do not send notifications if the resource has no title

* - Do not send notifications if the resource has no title

(cherry picked from commit c3d470e)

* - Asynchronous "probe" task for Remote Services

* [FIXES #6653] Mail notifications for private datasets are public

* - Fixes rating notifications

* - Fixes rating notifications

(cherry picked from commit b814692)

* - Fixes "guardian.exceptions.ObjectNotPersisted: Object None needs to be persisted first" exception on "set_workflow_perms" calls

* - Fixes "guardian.exceptions.ObjectNotPersisted: Object None needs to be persisted first" exception on "set_workflow_perms" calls

(cherry picked from commit fe35d46)

* - Fixes "guardian.exceptions.ObjectNotPersisted: Object None needs to be persisted first" exception on "set_workflow_perms" calls

* - Fixes "guardian.exceptions.ObjectNotPersisted: Object None needs to be persisted first" exception on "set_workflow_perms" calls

(cherry picked from commit dee7de1)

* - Fix LGTM issues

* - Fix LGTM issues

(cherry picked from commit 08644a6)

* - Fix LGTM issues

* - Fix LGTM issues

(cherry picked from commit df112c8)

* no notifications for resource owner, except for comments. PEP 8 reformatting

* resource owners will get notified on updates of their resources

* [Fixes #6665] Improve WYSIWYG metadata editor to store formatted and plain texts

* - Travis test-cases: "ensure owner won't be notified on upload"

* [Hardening] Do not fail in case of datastore with multiple geometries

* - Minor refactoring and clean out of the "geoserver_post_save_layers" task body

* [Hardening] Make "set_attributes" method more resilient to "Attribute.MultipleObjectsReturned" exception

* [Hardening] Make "helpers" methods more resilient to "Layer.MultipleObjectsReturned" and "Layer.DoesNotExist" exceptions

* - Minor environmnet params improvements. Exposing DB connection timeouts to .env

* - Explicit error codes along with description on Layer Upload form

* [Transaltions] - Explicit error codes along with description on Layer Upload form

* [Transaltions] - Explicit error codes along with description on Layer Upload form

(cherry picked from commit 395089e)

# Conflicts:
#	geonode/static/geonode/js/upload/LayerInfo.js
(cherry picked from commit f62b69a)

* [Docker] Use local nginx build

* Merge branch 'master' of https://github.com/GeoNode/geonode into rest_api_v2_geonode_apps

* [Hardening] More resiliet to 'missing thumbnail' on filesystem issues

* - GeoApp Test Cases

* - Typo

* - Update mapstore client and adapter versions

* - Set local .sh files exec perms

* - Bump pycsw to version 2.6.0

* - Bump pycsw to version 2.6.0

* - Bump pycsw to version 2.6.0

* - Align "setup.cfg" to "requirements.txt"

* - Fix travis

Co-authored-by: Toni <toni.schoenbuchner@csgis.de>
Co-authored-by: Piotr Dankowski <dankowski.revolve@gmail.com>
Co-authored-by: Florian Hoedt <gannebamm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor A low priority issue which might affect only some users and /or not the main functionality
Projects
No open projects
Development

No branches or pull requests

1 participant