Improve/fix GEONODE_APPS_ENABLE handling

[etj]

Expected Behavior

When GEONODE_APPS_ENABLE is false, GeoApps should not be displayed.

Actual Behavior

Even when setting GEONODE_APPS_ENABLE to False, GeoApps options and link show up in the GUI.

Specifications

• GeoNode version:
  • 3.3.x: happens here
  • master: not tested yet

[mattiagiupponi]

By analyzing this issue with @etj we found out some issues or questions.
By using the GEONODE_APPS_ENABLE to exclude the geoapp from GeoNode works, but partially.

The problem is that even if we hide from the UI the GeoApp, all the other GeoApp functionality is still available:

• Being able to use the API v1/v2 - Being able to call the apps/ URL and see the page
• The GeoApp are still available in the resource Search (normal and advanced)

The first idea that we had (probably not the cleanest one) is to redirect all the GeoApp views to a 404 page to block the user to call those pages.
This approach works but is not 100% definite, because the client will always add the endpoint of the GeoApp in the v2

Here is available a brief preview of the work done till now.

We are open to suggestions and discussions about this approach. @giohappy @afabiani any thoughts?

[etj]

Some more considerations: I do not expect this setting to be toggled very often.

ENABLE -> DISABLE transition:

This should be done only if geoapps were enable at first, in an environment where they are not needed.
Before changing the setting we could advise the admin to remove by hand all the geoapp instances created, so that they will not show up in the search.

DISABLE -> ENABLE transition:

Also this transition should be expected only once. I don't expect any problem in this transition.

[afabiani]

@etj @mattiagiupponi in my opinion if someone disables the geoapps everything should be disabled too, and the model excluded also. Of course this will have some consequences. If someone tries to remove this after the apps has been initialized and/or some GeoApp has been created already, this might have some impact/consequences.

I agree with @etj if we describe very well on the settings section how to correctly use this parameter, the solution would be much cleaner.

[afabiani]

@etj PRs backported on 3.3.x and 3.2.x

@giohappy we need some clarifications in order to understand what this option actually is supposed to do on master branch, since the GeoApps are tightly bounded to che client.