Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #9511] extrapolate FileUploadSizeLimit and UploadParallelismLi… #9528

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

mattiagiupponi
Copy link
Contributor

…mit limit from upload form

ref #9511

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jun 22, 2022
@mattiagiupponi mattiagiupponi self-assigned this Jun 22, 2022
@mattiagiupponi mattiagiupponi added this to the 4.0.0 milestone Jun 22, 2022
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #9528 (c25d288) into master (8a22df3) will increase coverage by 0.00%.
The diff coverage is 89.36%.

@@           Coverage Diff           @@
##           master    #9528   +/-   ##
=======================================
  Coverage   61.03%   61.03%           
=======================================
  Files         813      813           
  Lines       49881    49886    +5     
  Branches     7655     7656    +1     
=======================================
+ Hits        30443    30448    +5     
  Misses      17784    17784           
  Partials     1654     1654           

@mattiagiupponi mattiagiupponi marked this pull request as ready for review June 22, 2022 13:51
@mattiagiupponi mattiagiupponi changed the title WIP - [Fixes #9511] extrapolate FileUploadSizeLimit and UploadParallelismLi… [Fixes #9511] extrapolate FileUploadSizeLimit and UploadParallelismLi… Jun 22, 2022
@giohappy giohappy self-requested a review June 22, 2022 14:21
@mattiagiupponi mattiagiupponi merged commit b400ff7 into master Jun 22, 2022
@mattiagiupponi mattiagiupponi deleted the ISSUE_9511 branch June 22, 2022 15:21
github-actions bot pushed a commit that referenced this pull request Jun 22, 2022
#9528)

* [Fixes #9511] extrapolate FileUploadSizeLimit and UploadParallelismLimit limit from upload form

* [Fixes #9511] Fix test

Co-authored-by: Giovanni Allegri <giohappy@gmail.com>
afabiani pushed a commit that referenced this pull request Jun 23, 2022
#9528) (#9534)

* [Fixes #9511] extrapolate FileUploadSizeLimit and UploadParallelismLimit limit from upload form

* [Fixes #9511] Fix test

Co-authored-by: Giovanni Allegri <giohappy@gmail.com>

Co-authored-by: mattiagiupponi <51856725+mattiagiupponi@users.noreply.github.com>
Co-authored-by: Giovanni Allegri <giohappy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants