Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.x][Fixes #10208] Add a custom hook at the end of the permissions assign #10212

Merged
merged 2 commits into from Nov 4, 2022

Conversation

mattiagiupponi
Copy link
Contributor

@mattiagiupponi mattiagiupponi commented Oct 28, 2022

ref #10208

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi added this to the 4.0.2 milestone Oct 28, 2022
@mattiagiupponi mattiagiupponi self-assigned this Oct 28, 2022
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Oct 28, 2022
@mattiagiupponi mattiagiupponi changed the title [4.0.x][Fixes #10208] Add a custom hook at the end of the permissions assign WIP - [4.0.x][Fixes #10208] Add a custom hook at the end of the permissions assign Oct 28, 2022
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #10212 (c2388bd) into 4.0.x (5dec78d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##            4.0.x   #10212   +/-   ##
=======================================
  Coverage   61.72%   61.72%           
=======================================
  Files         825      825           
  Lines       50669    50672    +3     
  Branches     6540     6540           
=======================================
+ Hits        31274    31277    +3     
  Misses      17708    17708           
  Partials     1687     1687           

@mattiagiupponi mattiagiupponi changed the title WIP - [4.0.x][Fixes #10208] Add a custom hook at the end of the permissions assign [4.0.x][Fixes #10208] Add a custom hook at the end of the permissions assign Oct 28, 2022
@mattiagiupponi mattiagiupponi merged commit 81f378e into 4.0.x Nov 4, 2022
@mattiagiupponi mattiagiupponi deleted the 4xISSUE_10208 branch November 4, 2022 15:55
alaeddine-farhat pushed a commit to alaeddine-farhat/geonode that referenced this pull request Jun 7, 2023
…issions assign (GeoNode#10212)

* [Fixes GeoNode#10208] Add a custom hook at the end of the permissions assign
ridoo pushed a commit to Thuenen-GeoNode-Development/geonode that referenced this pull request Sep 18, 2023
…issions assign (GeoNode#10212)

* [Fixes GeoNode#10208] Add a custom hook at the end of the permissions assign
ridoo pushed a commit to Thuenen-GeoNode-Development/geonode that referenced this pull request Feb 22, 2024
…issions assign (GeoNode#10212)

* [Fixes GeoNode#10208] Add a custom hook at the end of the permissions assign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants