Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #10936] Implement a generic API endpoint for linked resources #10941

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

mattiagiupponi
Copy link
Contributor

@mattiagiupponi mattiagiupponi commented Apr 18, 2023

ref #10936

The API is filterable:

  • If the filter is related to the resource which we are asking the linked_resource we can use the dynamic filter example:

With the below URL, the filter will refer to the information of the resource PK and not to the linked resource. This is due to the behavior of the dynamic filter that geonode uses. We cannot change this

URL: /api/v2/{PK}/linked_resources?filter{resource_type}=map

With the below URL, the filter will refer to the linked resource. The filter accepts the default django queryset filtering

URL: /api/v2/{PK}/linked_resources?resource_type=map
URL: /api/v2/{PK}/linked_resources?title__icontains=title
URL: /api/v2/{PK}/linked_resources?resource_type=map

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi added this to the 4.1.0 milestone Apr 18, 2023
@mattiagiupponi mattiagiupponi self-assigned this Apr 18, 2023
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #10941 (45397ec) into master (2f12608) will increase coverage by 0.07%.
The diff coverage is 94.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10941      +/-   ##
==========================================
+ Coverage   62.22%   62.30%   +0.07%     
==========================================
  Files         828      828              
  Lines       51252    51367     +115     
  Branches     6564     6573       +9     
==========================================
+ Hits        31891    32002     +111     
- Misses      17666    17668       +2     
- Partials     1695     1697       +2     

@giohappy giohappy merged commit 9eb871d into master Apr 18, 2023
9 checks passed
@giohappy giohappy deleted the ISSUE_10936 branch April 18, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants