Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for ticket 777 #5

Merged
2 commits merged into from
Sep 30, 2010
Merged

Fixes for ticket 777 #5

2 commits merged into from
Sep 30, 2010

Conversation

ingenieroariel
Copy link
Member

Takes into consideration Rolando's suggestions. Labels are now on top of the field and title cased. This change affects the login form, the new account form and puts the capitalization in the site.css.

@dwins
Copy link
Contributor

dwins commented Sep 30, 2010

Shouldn't the <input> elements be outside of the <ul> for each form?

@ingenieroariel
Copy link
Member Author

I did it like that at first but they looked unaligned to me:

Outside the ul:
http://cl.ly/74a0a9cb3bcf410a5c1d

Inside the ul:
http://cl.ly/c31c9c4846640bb8b7d4

What do you think?

@dwins
Copy link
Contributor

dwins commented Sep 30, 2010

How do they look if you put them in their own <li>s?

@dwins
Copy link
Contributor

dwins commented Sep 30, 2010

Anyway, if we have to have direct children of a <ul> which are not <li>s I think we'll be okay; +1 to commit either way.

@ingenieroariel
Copy link
Member Author

They look the same (good):

http://cl.ly/738f4fe1da18b53e6a0f

@ingenieroariel
Copy link
Member Author

Added the

  • wrappers and committed. Thanks for the feedback.

  • ahocevar referenced this pull request in planetfederal/geonode Mar 29, 2012
    Thanks @bartvde for this excellent contribution (closes #5)
    mbertrand referenced this pull request in cga-harvard/geonode May 5, 2012
    Thanks @bartvde for this excellent contribution (closes #5)
    jj0hns0n referenced this pull request in jj0hns0n/geonode Jul 16, 2012
    add printing template endpoint
    simod added a commit that referenced this pull request May 15, 2014
    simboss referenced this pull request in geosolutions-it/geonode Sep 9, 2014
    Remove packaging from geoserver-geonode-ext repo.
    travislbrundage pushed a commit to travislbrundage/geonode that referenced this pull request Jul 8, 2015
    Prevent GeoExt lazy loading the layer.
    Vampouille added a commit to Vampouille/geonode that referenced this pull request Sep 12, 2017
    @codecov
    Copy link

    codecov bot commented Mar 19, 2019

    Codecov Report

    ❗ No coverage uploaded for pull request base (master@0ea452d). Click here to learn what that means.
    The diff coverage is 62.52%.

    @@            Coverage Diff            @@
    ##             master       #5   +/-   ##
    =========================================
      Coverage          ?   58.32%           
    =========================================
      Files             ?      175           
      Lines             ?    19490           
      Branches          ?     3214           
    =========================================
      Hits              ?    11367           
      Misses            ?     7102           
      Partials          ?     1021

    afabiani pushed a commit that referenced this pull request May 17, 2019
    Update UNSW-CFRC Geonode from master
    This pull request was closed.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    2 participants