[Fixes #5419] Hierarchical keyword and [Fixes #5446] Binary files removed /lib #5447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Fixes #5446 Fixes #5419
# 5419 Hierarchical keyword
Left paddings have been removed. Icons will not overlap anymore.
# 5446 binary files removed from lib
The lib directory which gets created from
grunt:production
has several binary files that are not respected on built.Things I've considered:
Files are already copied to /img further the gruntfile has a task to fix the different paths in css files https://github.com/GeoNode/geonode/blob/master/geonode/static/gruntfile.js#L109-L176
This means the cleanest way is just adding more replacements here.
❗ I've discarded this solution as most of the binaries are used for leaflet which is currently not fully working/testable.
Create a separate npm-package which only has the binary files in question, add it to package.json and sync files with grunt.
❗ I've discarded this solution as others might miss permissions to update the package.
Update static_dependencies.json and gruntfile to copy files to their destination.
✔️ I've chosen this solution even if it's a bit redundant
Therefore files in question are now mentioned in:
Checklist