Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #147

Closed
wants to merge 1 commit into from
Closed

Conversation

sdpeyton
Copy link
Collaborator

@sdpeyton sdpeyton commented Jan 5, 2019

Type of PR

  • Bug Fix
  • Feature
  • Maintenance

What is the Goal of the PR?

General dependency updates for maintenance. The main packages that were updated are:

  • webpack (move to v4)
  • documentation
  • turf

What is the Motivation for the PR?

  1. We are currently adding all of turf (@turf/turf) as a dependency, which feels a bit unnecessary and unduly heavy
  2. Webpack 4 has been out for a while now and is fairly stable, figured it was time to move over to it

What Tests are Included?

No tests included, but ran all tests locally after updating packages

@sdpeyton sdpeyton changed the title update dependencies to address security vulnerabilities update dependencies Jan 5, 2019
@DanielJDufour
Copy link
Member

Could you fix tests before merging? If not, I might try to check out this branch and add another commit to fix Travis CI issues before merging...

@DanielJDufour
Copy link
Member

P.S. I think issues with Travis CI are completely unrelated to changes that you made, but I'm not sure.

@DanielJDufour DanielJDufour mentioned this pull request Jan 6, 2019
1 task
@DanielJDufour
Copy link
Member

Superseeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants