fix(Private): rename private folders to internal

BREAKING CHANGE: change namespace detail in private folders to internal namespace
Geode-solutions · Jul 12, 2024 · 1335ff7 · 1335ff7
1 parent bb18afc
commit 1335ff7
Show file tree

Hide file tree

Showing 33 changed files with 97 additions and 96 deletions.
diff --git a/...ector/criterion/private/colocation_impl.h → ...ctor/criterion/internal/colocation_impl.h b/...ector/criterion/private/colocation_impl.h → ...ctor/criterion/internal/colocation_impl.h
@@ -30,7 +30,7 @@
 
 namespace geode
 {
-    namespace detail
+    namespace internal
     {
         /*!
          * Implementation of the inspection of the colocation of a Mesh
@@ -50,5 +50,5 @@ namespace geode
         private:
             const Mesh& mesh_;
         };
-    } // namespace detail
+    } // namespace internal
 } // namespace geode
diff --git a/...rion/private/component_meshes_adjacency.h → ...ion/internal/component_meshes_adjacency.h b/...rion/private/component_meshes_adjacency.h → ...ion/internal/component_meshes_adjacency.h
diff --git a/...n/private/component_meshes_degeneration.h → .../internal/component_meshes_degeneration.h b/...n/private/component_meshes_degeneration.h → .../internal/component_meshes_degeneration.h
diff --git a/...erion/private/component_meshes_manifold.h → ...rion/internal/component_meshes_manifold.h b/...erion/private/component_meshes_manifold.h → ...rion/internal/component_meshes_manifold.h
diff --git a/...tor/criterion/private/degeneration_impl.h → ...or/criterion/internal/degeneration_impl.h b/...tor/criterion/private/degeneration_impl.h → ...or/criterion/internal/degeneration_impl.h
@@ -28,7 +28,7 @@
 
 namespace geode
 {
-    namespace detail
+    namespace internal
     {
         /*!
          * Implementation of the inspection of the degeneration of a Mesh
@@ -54,5 +54,5 @@ namespace geode
         private:
             const Mesh& mesh_;
         };
-    } // namespace detail
+    } // namespace internal
 } // namespace geode
diff --git a/...ector/topology/private/topology_helpers.h → ...ctor/topology/internal/topology_helpers.h b/...ector/topology/private/topology_helpers.h → ...ctor/topology/internal/topology_helpers.h
@@ -43,7 +43,7 @@ namespace geode
 
 namespace geode
 {
-    namespace detail
+    namespace internal
     {
         bool brep_blocks_are_meshed( const BRep& brep );
 
@@ -77,5 +77,5 @@ namespace geode
                 const Section& section,
                 const ComponentID& component_id,
                 const VertexSet& component_mesh );
-    } // namespace detail
+    } // namespace internal
 } // namespace geode
diff --git a/src/geode/inspector/CMakeLists.txt b/src/geode/inspector/CMakeLists.txt
@@ -27,18 +27,18 @@ add_geode_library(
         "criterion/section_meshes_inspector.cpp"
         "criterion/adjacency/surface_adjacency.cpp"
         "criterion/adjacency/solid_adjacency.cpp"
-        "criterion/private/component_meshes_adjacency.cpp"
+        "criterion/internal/component_meshes_adjacency.cpp"
         "criterion/adjacency/section_meshes_adjacency.cpp"
         "criterion/adjacency/brep_meshes_adjacency.cpp"
-        "criterion/private/colocation_impl.cpp"
+        "criterion/internal/colocation_impl.cpp"
         "criterion/colocation/pointset_colocation.cpp"
         "criterion/colocation/edgedcurve_colocation.cpp"
         "criterion/colocation/surface_colocation.cpp"
         "criterion/colocation/solid_colocation.cpp"
         "criterion/colocation/unique_vertices_colocation.cpp"
         "criterion/colocation/component_meshes_colocation.cpp"
-        "criterion/private/degeneration_impl.cpp"
-        "criterion/private/component_meshes_degeneration.cpp"
+        "criterion/internal/degeneration_impl.cpp"
+        "criterion/internal/component_meshes_degeneration.cpp"
         "criterion/degeneration/edgedcurve_degeneration.cpp"
         "criterion/degeneration/surface_degeneration.cpp"
         "criterion/degeneration/solid_degeneration.cpp"
@@ -52,7 +52,7 @@ add_geode_library(
         "criterion/manifold/solid_vertex_manifold.cpp"
         "criterion/manifold/solid_edge_manifold.cpp"
         "criterion/manifold/solid_facet_manifold.cpp"
-        "criterion/private/component_meshes_manifold.cpp"
+        "criterion/internal/component_meshes_manifold.cpp"
         "criterion/manifold/section_meshes_manifold.cpp"
         "criterion/manifold/brep_meshes_manifold.cpp"
         "topology/brep_topology.cpp"
@@ -64,7 +64,7 @@ add_geode_library(
         "topology/section_corners_topology.cpp"
         "topology/section_lines_topology.cpp"
         "topology/section_surfaces_topology.cpp"
-        "topology/private/topology_helpers.cpp"
+        "topology/internal/topology_helpers.cpp"
         "section_inspector.cpp"
         "brep_inspector.cpp"
         "pointset_inspector.cpp"
@@ -110,20 +110,20 @@ add_geode_library(
         "edgedcurve_inspector.h"
         "surface_inspector.h"
         "solid_inspector.h"
-    PRIVATE_HEADERS
-        "criterion/private/colocation_impl.h"
-        "criterion/private/component_meshes_adjacency.h"
-        "criterion/private/component_meshes_degeneration.h"
-        "criterion/private/component_meshes_manifold.h"
-        "criterion/private/degeneration_impl.h"
+    INTERNAL_HEADERS
+        "criterion/internal/colocation_impl.h"
+        "criterion/internal/component_meshes_adjacency.h"
+        "criterion/internal/component_meshes_degeneration.h"
+        "criterion/internal/component_meshes_manifold.h"
+        "criterion/internal/degeneration_impl.h"
         "topology/brep_corners_topology.h"
         "topology/brep_lines_topology.h"
         "topology/brep_surfaces_topology.h"
         "topology/brep_blocks_topology.h"
         "topology/section_corners_topology.h"
         "topology/section_lines_topology.h"
         "topology/section_surfaces_topology.h"
-        "topology/private/topology_helpers.h"
+        "topology/internal/topology_helpers.h"
     PUBLIC_DEPENDENCIES
         OpenGeode::basic
     PRIVATE_DEPENDENCIES

diff --git a/src/geode/inspector/criterion/adjacency/brep_meshes_adjacency.cpp b/src/geode/inspector/criterion/adjacency/brep_meshes_adjacency.cpp
@@ -30,7 +30,7 @@
 #include <geode/model/representation/core/brep.h>
 
 #include <geode/inspector/criterion/adjacency/solid_adjacency.h>
-#include <geode/inspector/criterion/private/component_meshes_adjacency.h>
+#include <geode/inspector/criterion/internal/component_meshes_adjacency.h>
 
 namespace geode
 {

diff --git a/src/geode/inspector/criterion/adjacency/section_meshes_adjacency.cpp b/src/geode/inspector/criterion/adjacency/section_meshes_adjacency.cpp
@@ -28,7 +28,7 @@
 
 #include <geode/model/representation/core/section.h>
 
-#include <geode/inspector/criterion/private/component_meshes_adjacency.h>
+#include <geode/inspector/criterion/internal/component_meshes_adjacency.h>
 
 namespace geode
 {

diff --git a/src/geode/inspector/criterion/colocation/edgedcurve_colocation.cpp b/src/geode/inspector/criterion/colocation/edgedcurve_colocation.cpp
@@ -22,7 +22,7 @@
  */
 
 #include <geode/inspector/criterion/colocation/edgedcurve_colocation.h>
-#include <geode/inspector/criterion/private/colocation_impl.h>
+#include <geode/inspector/criterion/internal/colocation_impl.h>
 
 #include <geode/basic/logger.h>
 #include <geode/basic/pimpl_impl.h>
@@ -33,12 +33,12 @@ namespace geode
 {
     template < index_t dimension >
     class EdgedCurveColocation< dimension >::Impl
-        : public detail::ColocationImpl< dimension, EdgedCurve< dimension > >
+        : public internal::ColocationImpl< dimension, EdgedCurve< dimension > >
     {
     public:
         Impl( const EdgedCurve< dimension >& mesh )
-            : detail::ColocationImpl< dimension, EdgedCurve< dimension > >(
-                mesh )
+            : internal::ColocationImpl< dimension, EdgedCurve< dimension > >(
+                  mesh )
         {
         }
     };

diff --git a/src/geode/inspector/criterion/colocation/pointset_colocation.cpp b/src/geode/inspector/criterion/colocation/pointset_colocation.cpp
@@ -22,7 +22,7 @@
  */
 
 #include <geode/inspector/criterion/colocation/pointset_colocation.h>
-#include <geode/inspector/criterion/private/colocation_impl.h>
+#include <geode/inspector/criterion/internal/colocation_impl.h>
 
 #include <geode/basic/logger.h>
 #include <geode/basic/pimpl_impl.h>
@@ -33,11 +33,12 @@ namespace geode
 {
     template < index_t dimension >
     class PointSetColocation< dimension >::Impl
-        : public detail::ColocationImpl< dimension, PointSet< dimension > >
+        : public internal::ColocationImpl< dimension, PointSet< dimension > >
     {
     public:
         Impl( const PointSet< dimension >& mesh )
-            : detail::ColocationImpl< dimension, PointSet< dimension > >( mesh )
+            : internal::ColocationImpl< dimension, PointSet< dimension > >(
+                  mesh )
         {
         }
     };

diff --git a/src/geode/inspector/criterion/colocation/solid_colocation.cpp b/src/geode/inspector/criterion/colocation/solid_colocation.cpp
@@ -22,7 +22,7 @@
  */
 
 #include <geode/inspector/criterion/colocation/solid_colocation.h>
-#include <geode/inspector/criterion/private/colocation_impl.h>
+#include <geode/inspector/criterion/internal/colocation_impl.h>
 
 #include <geode/basic/logger.h>
 #include <geode/basic/pimpl_impl.h>
@@ -33,12 +33,12 @@ namespace geode
 {
     template < index_t dimension >
     class SolidMeshColocation< dimension >::Impl
-        : public detail::ColocationImpl< dimension, SolidMesh< dimension > >
+        : public internal::ColocationImpl< dimension, SolidMesh< dimension > >
     {
     public:
         Impl( const SolidMesh< dimension >& mesh )
-            : detail::ColocationImpl< dimension, SolidMesh< dimension > >(
-                mesh )
+            : internal::ColocationImpl< dimension, SolidMesh< dimension > >(
+                  mesh )
         {
         }
     };

diff --git a/src/geode/inspector/criterion/colocation/surface_colocation.cpp b/src/geode/inspector/criterion/colocation/surface_colocation.cpp
@@ -22,7 +22,7 @@
  */
 
 #include <geode/inspector/criterion/colocation/surface_colocation.h>
-#include <geode/inspector/criterion/private/colocation_impl.h>
+#include <geode/inspector/criterion/internal/colocation_impl.h>
 
 #include <geode/basic/logger.h>
 #include <geode/basic/pimpl_impl.h>
@@ -33,12 +33,12 @@ namespace geode
 {
     template < index_t dimension >
     class SurfaceMeshColocation< dimension >::Impl
-        : public detail::ColocationImpl< dimension, SurfaceMesh< dimension > >
+        : public internal::ColocationImpl< dimension, SurfaceMesh< dimension > >
     {
     public:
         Impl( const SurfaceMesh< dimension >& mesh )
-            : detail::ColocationImpl< dimension, SurfaceMesh< dimension > >(
-                mesh )
+            : internal::ColocationImpl< dimension, SurfaceMesh< dimension > >(
+                  mesh )
         {
         }
     };

diff --git a/src/geode/inspector/criterion/degeneration/brep_meshes_degeneration.cpp b/src/geode/inspector/criterion/degeneration/brep_meshes_degeneration.cpp
@@ -30,7 +30,7 @@
 #include <geode/model/representation/core/brep.h>
 
 #include <geode/inspector/criterion/degeneration/solid_degeneration.h>
-#include <geode/inspector/criterion/private/component_meshes_degeneration.h>
+#include <geode/inspector/criterion/internal/component_meshes_degeneration.h>
 
 namespace geode
 {

diff --git a/src/geode/inspector/criterion/degeneration/edgedcurve_degeneration.cpp b/src/geode/inspector/criterion/degeneration/edgedcurve_degeneration.cpp
@@ -22,7 +22,7 @@
  */
 
 #include <geode/inspector/criterion/degeneration/edgedcurve_degeneration.h>
-#include <geode/inspector/criterion/private/degeneration_impl.h>
+#include <geode/inspector/criterion/internal/degeneration_impl.h>
 
 #include <geode/basic/pimpl_impl.h>
 #include <geode/basic/uuid.h>

diff --git a/src/geode/inspector/criterion/degeneration/section_meshes_degeneration.cpp b/src/geode/inspector/criterion/degeneration/section_meshes_degeneration.cpp
@@ -30,7 +30,7 @@
 #include <geode/model/representation/core/section.h>
 
 #include <geode/inspector/criterion/degeneration/solid_degeneration.h>
-#include <geode/inspector/criterion/private/component_meshes_degeneration.h>
+#include <geode/inspector/criterion/internal/component_meshes_degeneration.h>
 
 namespace geode
 {

diff --git a/src/geode/inspector/criterion/degeneration/solid_degeneration.cpp b/src/geode/inspector/criterion/degeneration/solid_degeneration.cpp
@@ -22,7 +22,7 @@
  */
 
 #include <geode/inspector/criterion/degeneration/solid_degeneration.h>
-#include <geode/inspector/criterion/private/degeneration_impl.h>
+#include <geode/inspector/criterion/internal/degeneration_impl.h>
 
 #include <geode/basic/logger.h>
 #include <geode/basic/pimpl_impl.h>
@@ -37,17 +37,17 @@ namespace geode
 {
     template < index_t dimension >
     class SolidMeshDegeneration< dimension >::Impl
-        : public detail::DegenerationImpl< SolidMesh< dimension > >
+        : public internal::DegenerationImpl< SolidMesh< dimension > >
     {
     public:
         Impl( const SolidMesh< dimension >& mesh )
-            : detail::DegenerationImpl< SolidMesh< dimension > >{ mesh }
+            : internal::DegenerationImpl< SolidMesh< dimension > >{ mesh }
         {
         }
 
         bool is_mesh_degenerated() const final
         {
-            if( this->detail::DegenerationImpl<
+            if( this->internal::DegenerationImpl<
                     SolidMesh< dimension > >::is_mesh_degenerated() )
             {
                 return true;

diff --git a/src/geode/inspector/criterion/degeneration/surface_degeneration.cpp b/src/geode/inspector/criterion/degeneration/surface_degeneration.cpp
@@ -22,7 +22,7 @@
  */
 
 #include <geode/inspector/criterion/degeneration/surface_degeneration.h>
-#include <geode/inspector/criterion/private/degeneration_impl.h>
+#include <geode/inspector/criterion/internal/degeneration_impl.h>
 
 #include <geode/basic/logger.h>
 #include <geode/basic/pimpl_impl.h>
@@ -37,17 +37,17 @@ namespace geode
 {
     template < index_t dimension >
     class SurfaceMeshDegeneration< dimension >::Impl
-        : public detail::DegenerationImpl< SurfaceMesh< dimension > >
+        : public internal::DegenerationImpl< SurfaceMesh< dimension > >
     {
     public:
         Impl( const SurfaceMesh< dimension >& mesh )
-            : detail::DegenerationImpl< SurfaceMesh< dimension > >{ mesh }
+            : internal::DegenerationImpl< SurfaceMesh< dimension > >{ mesh }
         {
         }
 
         bool is_mesh_degenerated() const final
         {
-            if( this->detail::DegenerationImpl<
+            if( this->internal::DegenerationImpl<
                     SurfaceMesh< dimension > >::is_mesh_degenerated() )
             {
                 return true;

diff --git a/...tor/criterion/private/colocation_impl.cpp → ...or/criterion/internal/colocation_impl.cpp b/...tor/criterion/private/colocation_impl.cpp → ...or/criterion/internal/colocation_impl.cpp
@@ -21,7 +21,7 @@
  *
  */
 
-#include <geode/inspector/criterion/private/colocation_impl.h>
+#include <geode/inspector/criterion/internal/colocation_impl.h>
 
 #include <geode/basic/logger.h>
 
@@ -97,7 +97,7 @@ namespace
 
 namespace geode
 {
-    namespace detail
+    namespace internal
     {
         template < index_t dimension, typename Mesh >
         ColocationImpl< dimension, Mesh >::ColocationImpl( const Mesh& mesh )
@@ -139,5 +139,5 @@ namespace geode
             ColocationImpl< 3, SurfaceMesh3D >;
         template class opengeode_inspector_inspector_api
             ColocationImpl< 3, SolidMesh3D >;
-    } // namespace detail
+    } // namespace internal
 } // namespace geode
diff --git a/...on/private/component_meshes_adjacency.cpp → ...n/internal/component_meshes_adjacency.cpp b/...on/private/component_meshes_adjacency.cpp → ...n/internal/component_meshes_adjacency.cpp
@@ -21,7 +21,7 @@
  *
  */
 
-#include <geode/inspector/criterion/private/component_meshes_adjacency.h>
+#include <geode/inspector/criterion/internal/component_meshes_adjacency.h>
 
 #include <geode/basic/logger.h>
 

diff --git a/...private/component_meshes_degeneration.cpp → ...nternal/component_meshes_degeneration.cpp b/...private/component_meshes_degeneration.cpp → ...nternal/component_meshes_degeneration.cpp
@@ -21,7 +21,7 @@
  *
  */
 
-#include <geode/inspector/criterion/private/component_meshes_degeneration.h>
+#include <geode/inspector/criterion/internal/component_meshes_degeneration.h>
 
 #include <geode/basic/logger.h>
 

diff --git a/...ion/private/component_meshes_manifold.cpp → ...on/internal/component_meshes_manifold.cpp b/...ion/private/component_meshes_manifold.cpp → ...on/internal/component_meshes_manifold.cpp
@@ -21,7 +21,7 @@
  *
  */
 
-#include <geode/inspector/criterion/private/component_meshes_manifold.h>
+#include <geode/inspector/criterion/internal/component_meshes_manifold.h>
 
 #include <geode/basic/logger.h>
 

diff --git a/...r/criterion/private/degeneration_impl.cpp → .../criterion/internal/degeneration_impl.cpp b/...r/criterion/private/degeneration_impl.cpp → .../criterion/internal/degeneration_impl.cpp
@@ -21,7 +21,7 @@
  *
  */
 
-#include <geode/inspector/criterion/private/degeneration_impl.h>
+#include <geode/inspector/criterion/internal/degeneration_impl.h>
 
 #include <geode/basic/uuid.h>
 
@@ -35,7 +35,7 @@
 
 namespace geode
 {
-    namespace detail
+    namespace internal
     {
         template < class MeshType >
         DegenerationImpl< MeshType >::DegenerationImpl( const MeshType& mesh )
@@ -109,5 +109,5 @@ namespace geode
             DegenerationImpl< SurfaceMesh3D >;
         template class opengeode_inspector_inspector_api
             DegenerationImpl< SolidMesh3D >;
-    } // namespace detail
+    } // namespace internal
 } // namespace geode