Skip to content

Commit

Permalink
Merge branch 'v15' into fix_v15/rename_global_epsilon_to_GLOBAL_EPSILON
Browse files Browse the repository at this point in the history
  • Loading branch information
benoit2776 committed Jul 12, 2024
2 parents b3f36cf + bb18afc commit 3a42365
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 11 deletions.
5 changes: 0 additions & 5 deletions bindings/python/src/inspector/inspector.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,6 @@ namespace pybind11
{
};

template <>
struct type_caster< absl::string_view >
: string_caster< absl::string_view, true >
{
};
} // namespace detail
} // namespace pybind11

Expand Down
12 changes: 6 additions & 6 deletions include/geode/inspector/information.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,14 @@ namespace geode
class InspectionIssues
{
public:
explicit InspectionIssues( absl::string_view issue_description )
explicit InspectionIssues( std::string_view issue_description )
: description_{ issue_description }
{
}

InspectionIssues() = default;

void set_description( absl::string_view issue_description )
void set_description( std::string_view issue_description )
{
description_ = to_string( issue_description );
}
Expand All @@ -63,7 +63,7 @@ namespace geode
messages_.emplace_back( std::move( message ) );
}

absl::string_view description() const
std::string_view description() const
{
return description_;
}
Expand Down Expand Up @@ -100,19 +100,19 @@ namespace geode
class InspectionIssuesMap
{
public:
explicit InspectionIssuesMap( absl::string_view issue_description )
explicit InspectionIssuesMap( std::string_view issue_description )
: description_{ issue_description }
{
}

InspectionIssuesMap() = default;

void set_description( absl::string_view issue_description )
void set_description( std::string_view issue_description )
{
description_ = to_string( issue_description );
}

absl::string_view description() const
std::string_view description() const
{
return description_;
}
Expand Down

0 comments on commit 3a42365

Please sign in to comment.