fix(explicit constructor): Added explicit constructors and updated wi…

…th those in OpenGeode.
Geode-solutions · Jul 5, 2024 · df48bd0 · df48bd0
1 parent 771f78b
commit df48bd0
Show file tree

Hide file tree

Showing 63 changed files with 404 additions and 387 deletions.
diff --git a/include/geode/inspector/brep_inspector.h b/include/geode/inspector/brep_inspector.h
@@ -56,7 +56,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( BRepInspector );
 
     public:
-        BRepInspector( const BRep& brep );
+        explicit BRepInspector( const BRep& brep );
 
         BRepInspectionResult inspect_brep() const;
     };

diff --git a/include/geode/inspector/criterion/adjacency/brep_meshes_adjacency.h b/include/geode/inspector/criterion/adjacency/brep_meshes_adjacency.h
@@ -66,7 +66,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( BRepComponentMeshesAdjacency );
 
     public:
-        BRepComponentMeshesAdjacency( const BRep& model );
+        explicit BRepComponentMeshesAdjacency( const BRep& model );
 
         ~BRepComponentMeshesAdjacency();
 

diff --git a/include/geode/inspector/criterion/adjacency/section_meshes_adjacency.h b/include/geode/inspector/criterion/adjacency/section_meshes_adjacency.h
@@ -40,8 +40,8 @@ namespace geode
 
 namespace geode
 {
-    struct opengeode_inspector_inspector_api
-        SectionMeshesAdjacencyInspectionResult
+    struct
+        opengeode_inspector_inspector_api SectionMeshesAdjacencyInspectionResult
     {
         InspectionIssuesMap< PolygonEdge >
             surfaces_edges_with_wrong_adjacencies{
@@ -61,7 +61,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( SectionComponentMeshesAdjacency );
 
     public:
-        SectionComponentMeshesAdjacency( const Section& model );
+        explicit SectionComponentMeshesAdjacency( const Section& model );
 
         ~SectionComponentMeshesAdjacency();
 

diff --git a/include/geode/inspector/criterion/adjacency/solid_adjacency.h b/include/geode/inspector/criterion/adjacency/solid_adjacency.h
@@ -45,7 +45,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( SolidMeshAdjacency );
 
     public:
-        SolidMeshAdjacency( const SolidMesh< dimension >& mesh );
+        explicit SolidMeshAdjacency( const SolidMesh< dimension >& mesh );
 
         ~SolidMeshAdjacency();
 

diff --git a/include/geode/inspector/criterion/adjacency/surface_adjacency.h b/include/geode/inspector/criterion/adjacency/surface_adjacency.h
@@ -45,7 +45,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( SurfaceMeshAdjacency );
 
     public:
-        SurfaceMeshAdjacency( const SurfaceMesh< dimension >& mesh );
+        explicit SurfaceMeshAdjacency( const SurfaceMesh< dimension >& mesh );
 
         ~SurfaceMeshAdjacency();
 

diff --git a/include/geode/inspector/criterion/brep_meshes_inspector.h b/include/geode/inspector/criterion/brep_meshes_inspector.h
@@ -62,7 +62,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( BRepMeshesInspector );
 
     public:
-        BRepMeshesInspector( const BRep& brep );
+        explicit BRepMeshesInspector( const BRep& brep );
 
         BRepMeshesInspectionResult inspect_brep_meshes() const;
     };

diff --git a/include/geode/inspector/criterion/colocation/component_meshes_colocation.h b/include/geode/inspector/criterion/colocation/component_meshes_colocation.h
@@ -59,7 +59,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( ComponentMeshesColocation );
 
     public:
-        ComponentMeshesColocation( const Model& model );
+        explicit ComponentMeshesColocation( const Model& model );
 
         ~ComponentMeshesColocation();
 

diff --git a/include/geode/inspector/criterion/colocation/edgedcurve_colocation.h b/include/geode/inspector/criterion/colocation/edgedcurve_colocation.h
@@ -44,7 +44,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( EdgedCurveColocation );
 
     public:
-        EdgedCurveColocation( const EdgedCurve< dimension >& mesh );
+        explicit EdgedCurveColocation( const EdgedCurve< dimension >& mesh );
 
         ~EdgedCurveColocation();
 

diff --git a/include/geode/inspector/criterion/colocation/pointset_colocation.h b/include/geode/inspector/criterion/colocation/pointset_colocation.h
@@ -44,7 +44,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( PointSetColocation );
 
     public:
-        PointSetColocation( const PointSet< dimension >& mesh );
+        explicit PointSetColocation( const PointSet< dimension >& mesh );
 
         ~PointSetColocation();
 

diff --git a/include/geode/inspector/criterion/colocation/solid_colocation.h b/include/geode/inspector/criterion/colocation/solid_colocation.h
@@ -45,7 +45,7 @@ namespace geode
         OPENGEODE_TEMPLATE_ASSERT_3D( dimension );
 
     public:
-        SolidMeshColocation( const SolidMesh< dimension >& mesh );
+        explicit SolidMeshColocation( const SolidMesh< dimension >& mesh );
 
         ~SolidMeshColocation();
 

diff --git a/include/geode/inspector/criterion/colocation/surface_colocation.h b/include/geode/inspector/criterion/colocation/surface_colocation.h
@@ -44,7 +44,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( SurfaceMeshColocation );
 
     public:
-        SurfaceMeshColocation( const SurfaceMesh< dimension >& mesh );
+        explicit SurfaceMeshColocation( const SurfaceMesh< dimension >& mesh );
 
         ~SurfaceMeshColocation();
 

diff --git a/include/geode/inspector/criterion/colocation/unique_vertices_colocation.h b/include/geode/inspector/criterion/colocation/unique_vertices_colocation.h
@@ -62,7 +62,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( UniqueVerticesColocation );
 
     public:
-        UniqueVerticesColocation( const Model& model );
+        explicit UniqueVerticesColocation( const Model& model );
 
         ~UniqueVerticesColocation();
 

diff --git a/include/geode/inspector/criterion/degeneration/brep_meshes_degeneration.h b/include/geode/inspector/criterion/degeneration/brep_meshes_degeneration.h
@@ -38,8 +38,8 @@ namespace geode
 
 namespace geode
 {
-    struct opengeode_inspector_inspector_api
-        BRepMeshesDegenerationInspectionResult
+    struct
+        opengeode_inspector_inspector_api BRepMeshesDegenerationInspectionResult
     {
         InspectionIssuesMap< index_t > degenerated_edges{
             "BRep component meshes with degenerated edges"
@@ -65,7 +65,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( BRepComponentMeshesDegeneration );
 
     public:
-        BRepComponentMeshesDegeneration( const BRep& brep );
+        explicit BRepComponentMeshesDegeneration( const BRep& brep );
 
         ~BRepComponentMeshesDegeneration();
 

diff --git a/include/geode/inspector/criterion/degeneration/edgedcurve_degeneration.h b/include/geode/inspector/criterion/degeneration/edgedcurve_degeneration.h
@@ -44,7 +44,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( EdgedCurveDegeneration );
 
     public:
-        EdgedCurveDegeneration( const EdgedCurve< dimension >& mesh );
+        explicit EdgedCurveDegeneration( const EdgedCurve< dimension >& mesh );
 
         ~EdgedCurveDegeneration();
 

diff --git a/include/geode/inspector/criterion/degeneration/section_meshes_degeneration.h b/include/geode/inspector/criterion/degeneration/section_meshes_degeneration.h
@@ -38,8 +38,8 @@ namespace geode
 
 namespace geode
 {
-    struct opengeode_inspector_inspector_api
-        SectionMeshesDegenerationInspectionResult
+    struct
+        opengeode_inspector_inspector_api SectionMeshesDegenerationInspectionResult
     {
         InspectionIssuesMap< index_t > degenerated_edges{
             "Section component meshes with degenerated edges"
@@ -62,7 +62,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( SectionComponentMeshesDegeneration );
 
     public:
-        SectionComponentMeshesDegeneration( const Section& section );
+        explicit SectionComponentMeshesDegeneration( const Section& section );
 
         ~SectionComponentMeshesDegeneration();
 

diff --git a/include/geode/inspector/criterion/degeneration/solid_degeneration.h b/include/geode/inspector/criterion/degeneration/solid_degeneration.h
@@ -45,7 +45,7 @@ namespace geode
         OPENGEODE_TEMPLATE_ASSERT_3D( dimension );
 
     public:
-        SolidMeshDegeneration( const SolidMesh< dimension >& mesh );
+        explicit SolidMeshDegeneration( const SolidMesh< dimension >& mesh );
 
         ~SolidMeshDegeneration();
 

diff --git a/include/geode/inspector/criterion/degeneration/surface_degeneration.h b/include/geode/inspector/criterion/degeneration/surface_degeneration.h
@@ -44,7 +44,8 @@ namespace geode
         OPENGEODE_DISABLE_COPY( SurfaceMeshDegeneration );
 
     public:
-        SurfaceMeshDegeneration( const SurfaceMesh< dimension >& mesh );
+        explicit SurfaceMeshDegeneration(
+            const SurfaceMesh< dimension >& mesh );
 
         ~SurfaceMeshDegeneration();
 

diff --git a/include/geode/inspector/criterion/intersections/model_intersections.h b/include/geode/inspector/criterion/intersections/model_intersections.h
@@ -38,8 +38,8 @@ namespace geode
 
 namespace geode
 {
-    struct opengeode_inspector_inspector_api
-        ElementsIntersectionsInspectionResult
+    struct
+        opengeode_inspector_inspector_api ElementsIntersectionsInspectionResult
     {
         InspectionIssues<
             std::pair< ComponentMeshElement, ComponentMeshElement > >
@@ -59,7 +59,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( ModelMeshesIntersections );
 
     public:
-        ModelMeshesIntersections( const Model& model );
+        explicit ModelMeshesIntersections( const Model& model );
 
         ~ModelMeshesIntersections();
 

diff --git a/include/geode/inspector/criterion/intersections/surface_curve_intersections.h b/include/geode/inspector/criterion/intersections/surface_curve_intersections.h
@@ -47,7 +47,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( SurfaceCurveIntersections );
 
     public:
-        SurfaceCurveIntersections(
+       explicit SurfaceCurveIntersections(
             const TriangulatedSurface< dimension >& surface,
             const EdgedCurve< dimension >& curve );
 

diff --git a/include/geode/inspector/criterion/intersections/surface_intersections.h b/include/geode/inspector/criterion/intersections/surface_intersections.h
@@ -46,7 +46,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( TriangulatedSurfaceIntersections );
 
     public:
-        TriangulatedSurfaceIntersections(
+        explicit TriangulatedSurfaceIntersections(
             const TriangulatedSurface< dimension >& mesh );
 
         ~TriangulatedSurfaceIntersections();

diff --git a/include/geode/inspector/criterion/manifold/brep_meshes_manifold.h b/include/geode/inspector/criterion/manifold/brep_meshes_manifold.h
@@ -78,7 +78,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( BRepComponentMeshesManifold );
 
     public:
-        BRepComponentMeshesManifold( const BRep& brep );
+        explicit BRepComponentMeshesManifold( const BRep& brep );
 
         ~BRepComponentMeshesManifold();
 

diff --git a/include/geode/inspector/criterion/manifold/section_meshes_manifold.h b/include/geode/inspector/criterion/manifold/section_meshes_manifold.h
@@ -35,8 +35,8 @@
 
 namespace geode
 {
-    struct opengeode_inspector_inspector_api
-        SectionMeshesManifoldInspectionResult
+    struct
+        opengeode_inspector_inspector_api SectionMeshesManifoldInspectionResult
     {
         InspectionIssuesMap< index_t > meshes_non_manifold_vertices{
             "Section component meshes with non manifold vertices"
@@ -59,7 +59,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( SectionComponentMeshesManifold );
 
     public:
-        SectionComponentMeshesManifold( const Section& section );
+        explicit SectionComponentMeshesManifold( const Section& section );
 
         ~SectionComponentMeshesManifold();
 

diff --git a/include/geode/inspector/criterion/manifold/solid_edge_manifold.h b/include/geode/inspector/criterion/manifold/solid_edge_manifold.h
@@ -51,7 +51,7 @@ namespace geode
         OPENGEODE_TEMPLATE_ASSERT_3D( dimension );
 
     public:
-        SolidMeshEdgeManifold( const SolidMesh< dimension >& mesh );
+        explicit SolidMeshEdgeManifold( const SolidMesh< dimension >& mesh );
 
         ~SolidMeshEdgeManifold();
 

diff --git a/include/geode/inspector/criterion/manifold/solid_facet_manifold.h b/include/geode/inspector/criterion/manifold/solid_facet_manifold.h
@@ -44,7 +44,7 @@ namespace geode
         OPENGEODE_TEMPLATE_ASSERT_3D( dimension );
 
     public:
-        SolidMeshFacetManifold( const SolidMesh< dimension >& mesh );
+        explicit SolidMeshFacetManifold( const SolidMesh< dimension >& mesh );
 
         ~SolidMeshFacetManifold();
 

diff --git a/include/geode/inspector/criterion/manifold/solid_vertex_manifold.h b/include/geode/inspector/criterion/manifold/solid_vertex_manifold.h
@@ -45,7 +45,7 @@ namespace geode
         OPENGEODE_TEMPLATE_ASSERT_3D( dimension );
 
     public:
-        SolidMeshVertexManifold( const SolidMesh< dimension >& mesh );
+        explicit SolidMeshVertexManifold( const SolidMesh< dimension >& mesh );
 
         ~SolidMeshVertexManifold();
 

diff --git a/include/geode/inspector/criterion/manifold/surface_edge_manifold.h b/include/geode/inspector/criterion/manifold/surface_edge_manifold.h
@@ -50,7 +50,8 @@ namespace geode
         OPENGEODE_DISABLE_COPY( SurfaceMeshEdgeManifold );
 
     public:
-        SurfaceMeshEdgeManifold( const SurfaceMesh< dimension >& mesh );
+        explicit SurfaceMeshEdgeManifold(
+            const SurfaceMesh< dimension >& mesh );
 
         ~SurfaceMeshEdgeManifold();
 

diff --git a/include/geode/inspector/criterion/manifold/surface_vertex_manifold.h b/include/geode/inspector/criterion/manifold/surface_vertex_manifold.h
@@ -44,7 +44,8 @@ namespace geode
         OPENGEODE_DISABLE_COPY( SurfaceMeshVertexManifold );
 
     public:
-        SurfaceMeshVertexManifold( const SurfaceMesh< dimension >& mesh );
+        explicit SurfaceMeshVertexManifold(
+            const SurfaceMesh< dimension >& mesh );
 
         ~SurfaceMeshVertexManifold();
 

diff --git a/include/geode/inspector/criterion/private/colocation_impl.h b/include/geode/inspector/criterion/private/colocation_impl.h
@@ -39,7 +39,7 @@ namespace geode
         class ColocationImpl
         {
         protected:
-            ColocationImpl( const Mesh& mesh );
+            explicit ColocationImpl( const Mesh& mesh );
 
         public:
             bool mesh_has_colocated_points() const;

diff --git a/include/geode/inspector/criterion/private/component_meshes_adjacency.h b/include/geode/inspector/criterion/private/component_meshes_adjacency.h
@@ -50,7 +50,7 @@ namespace geode
             InspectionIssuesMap< PolygonEdge >& issues_map ) const;
 
     protected:
-        ComponentMeshesAdjacency( const Model& model );
+        explicit ComponentMeshesAdjacency( const Model& model );
 
         const Model& model() const;
 

diff --git a/include/geode/inspector/criterion/private/component_meshes_degeneration.h b/include/geode/inspector/criterion/private/component_meshes_degeneration.h
@@ -53,7 +53,7 @@ namespace geode
             InspectionIssuesMap< index_t >& issues_map ) const;
 
     protected:
-        ComponentMeshesDegeneration( const Model& model );
+        explicit ComponentMeshesDegeneration( const Model& model );
 
         const Model& model() const;
 

diff --git a/include/geode/inspector/criterion/private/component_meshes_manifold.h b/include/geode/inspector/criterion/private/component_meshes_manifold.h
@@ -49,7 +49,7 @@ namespace geode
             InspectionIssuesMap< std::array< index_t, 2 > >& issues_map ) const;
 
     protected:
-        ComponentMeshesManifold( const Model& model );
+        explicit ComponentMeshesManifold( const Model& model );
 
         const Model& model() const;
 

diff --git a/include/geode/inspector/criterion/private/degeneration_impl.h b/include/geode/inspector/criterion/private/degeneration_impl.h
@@ -47,7 +47,7 @@ namespace geode
             bool edge_is_degenerated( index_t edge_index ) const;
 
         protected:
-            DegenerationImpl( const Mesh& mesh );
+            explicit DegenerationImpl( const Mesh& mesh );
 
             const Mesh& mesh() const;
 

diff --git a/include/geode/inspector/criterion/section_meshes_inspector.h b/include/geode/inspector/criterion/section_meshes_inspector.h
@@ -62,7 +62,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( SectionMeshesInspector );
 
     public:
-        SectionMeshesInspector( const Section& section );
+        explicit SectionMeshesInspector( const Section& section );
 
         SectionMeshesInspectionResult inspect_section_meshes() const;
     };

diff --git a/include/geode/inspector/edgedcurve_inspector.h b/include/geode/inspector/edgedcurve_inspector.h
@@ -57,7 +57,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( EdgedCurveInspector );
 
     public:
-        EdgedCurveInspector( const EdgedCurve< dimension >& mesh );
+        explicit EdgedCurveInspector( const EdgedCurve< dimension >& mesh );
 
         EdgedCurveInspectionResult inspect_edged_curve() const;
     };

diff --git a/include/geode/inspector/mixin/add_inspectors.h b/include/geode/inspector/mixin/add_inspectors.h
@@ -38,7 +38,7 @@ namespace geode
     class AddInspectors : public Inspectors...
     {
     protected:
-        AddInspectors( const Mesh& mesh ) : Inspectors{ mesh }... {}
+        explicit AddInspectors( const Mesh& mesh ) : Inspectors{ mesh }... {}
         AddInspectors( AddInspectors&& ) = default;
     };
 } // namespace geode
diff --git a/include/geode/inspector/pointset_inspector.h b/include/geode/inspector/pointset_inspector.h
@@ -51,7 +51,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( PointSetInspector );
 
     public:
-        PointSetInspector( const PointSet< dimension >& mesh );
+        explicit PointSetInspector( const PointSet< dimension >& mesh );
 
         PointSetInspectionResult inspect_point_set() const;
     };

diff --git a/include/geode/inspector/section_inspector.h b/include/geode/inspector/section_inspector.h
@@ -51,7 +51,7 @@ namespace geode
         OPENGEODE_DISABLE_COPY( SectionInspector );
 
     public:
-        SectionInspector( const Section& section );
+       explicit SectionInspector( const Section& section );
 
         SectionInspectionResult inspect_section() const;
     };

diff --git a/include/geode/inspector/solid_inspector.h b/include/geode/inspector/solid_inspector.h
@@ -82,7 +82,7 @@ namespace geode
         OPENGEODE_TEMPLATE_ASSERT_3D( dimension );
 
     public:
-        SolidMeshInspector( const SolidMesh< dimension >& mesh );
+        explicit SolidMeshInspector( const SolidMesh< dimension >& mesh );
         SolidInspectionResult inspect_solid() const;
     };
     ALIAS_3D( SolidMeshInspector );