Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SolidEXE): missing adjacency check in the executable #68

Merged
merged 2 commits into from
Aug 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/python/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
# pip-compile --pre bindings/python/requirements.in
#
opengeode-core==14.*,>=14.5.0rc8
opengeode-core==14.*,>=14.5.0rc9
# via
# -r bindings/python/requirements.in
# opengeode-geosciences
Expand Down
12 changes: 11 additions & 1 deletion src/bin/geode-inspector-solid.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
#include <geode/inspector/solid_inspector.h>

ABSL_FLAG( std::string, input, "/path/my/solid.og_tso3d", "Input solid" );
ABSL_FLAG( bool, adjacency, true, "Toggle adjacency criterion" );
ABSL_FLAG( bool, colocation, true, "Toggle colocation criterion" );
ABSL_FLAG( bool, degeneration, true, "Toggle degeneration criterion" );
ABSL_FLAG( bool, manifold_vertex, true, "Toggle manifold vertex criterion" );
Expand All @@ -61,8 +62,17 @@ template < geode::index_t dimension >
void inspect_solid( const geode::SolidMesh< dimension >& solid )
{
const auto verbose = absl::GetFlag( FLAGS_verbose );
absl::InlinedVector< async::task< void >, 6 > tasks;
constexpr auto nb_tasks = 7;
absl::InlinedVector< async::task< void >, nb_tasks > tasks;
const geode::SolidMeshInspector< dimension > inspector{ solid, verbose };

if( absl::GetFlag( FLAGS_adjacency ) )
{
tasks.emplace_back( async::spawn( [&inspector] {
const auto nb_facets = inspector.nb_facets_with_wrong_adjacency();
geode::Logger::info( nb_facets, " facets with wrong adjacency" );
} ) );
}
if( absl::GetFlag( FLAGS_colocation ) )
{
tasks.emplace_back( async::spawn( [&inspector] {
Expand Down