Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat meshes inspector #79

Merged
merged 24 commits into from
Dec 15, 2023

Conversation

francoisbonneau
Copy link
Member

No description provided.

include/geode/inspector/criterion/brep_meshes_inspector.h Outdated Show resolved Hide resolved
include/geode/inspector/information.h Outdated Show resolved Hide resolved
src/bin/geode-inspector-brep.cpp Outdated Show resolved Hide resolved
src/geode/inspector/topology/brep_topology.cpp Outdated Show resolved Hide resolved
src/geode/inspector/topology/private/topology_helpers.cpp Outdated Show resolved Hide resolved
src/geode/inspector/topology/section_surfaces_topology.cpp Outdated Show resolved Hide resolved
src/geode/inspector/topology/section_topology.cpp Outdated Show resolved Hide resolved
src/geode/inspector/topology/section_topology.cpp Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 826. Check the log or trigger a new build to see more.

@francoisbonneau francoisbonneau marked this pull request as ready for review December 15, 2023 16:11
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 801. Check the log or trigger a new build to see more.

@@ -37,11 +37,8 @@ namespace geode
absl::StrCat( "SurfaceMeshAdjacency", dimension, "D" );
pybind11::class_< SurfaceMeshAdjacency >( module, name.c_str() )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: unexpected type name 'SurfaceMeshAdjacency': expected expression [clang-diagnostic-error]

        pybind11::class_< SurfaceMeshAdjacency >( module, name.c_str() )
                          ^

@@ -37,11 +37,8 @@ namespace geode
absl::StrCat( "SurfaceMeshAdjacency", dimension, "D" );
pybind11::class_< SurfaceMeshAdjacency >( module, name.c_str() )
.def( pybind11::init< const SurfaceMesh& >() )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

            .def( pybind11::init< const SurfaceMesh& >() )
                  ^

@@ -37,11 +37,8 @@ namespace geode
absl::StrCat( "SurfaceMeshAdjacency", dimension, "D" );
pybind11::class_< SurfaceMeshAdjacency >( module, name.c_str() )
.def( pybind11::init< const SurfaceMesh& >() )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init< const SurfaceMesh& >() )
                                  ^

Comment on lines +28 to +29
#include <geode/inspector/criterion/brep_meshes_inspector.h>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: included header brep_meshes_inspector.h is not used directly [misc-include-cleaner]

Suggested change
#include <geode/inspector/criterion/brep_meshes_inspector.h>

@@ -25,16 +25,42 @@

#include <geode/inspector/brep_inspector.h>

#include <geode/inspector/criterion/brep_meshes_inspector.h>

namespace geode
{
void define_brep_inspector( pybind11::module& module )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

    void define_brep_inspector( pybind11::module& module )
                                ^


namespace geode
{
void define_models_meshes_colocation( pybind11::module& module )
{
pybind11::class_< MeshesColocationInspectionResult >(
module, "MeshesColocationInspectionResult" )
.def( pybind11::init<>() )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]

            .def( pybind11::init<>() )
                  ^


namespace geode
{
void define_models_meshes_colocation( pybind11::module& module )
{
pybind11::class_< MeshesColocationInspectionResult >(
module, "MeshesColocationInspectionResult" )
.def( pybind11::init<>() )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init<>() )
                                 ^


namespace geode
{
void define_models_meshes_colocation( pybind11::module& module )
{
pybind11::class_< MeshesColocationInspectionResult >(
module, "MeshesColocationInspectionResult" )
.def( pybind11::init<>() )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

            .def( pybind11::init<>() )
                                   ^

.def_readwrite( "colocated_points_groups",
&MeshesColocationInspectionResult::colocated_points_groups )
.def( "string", &MeshesColocationInspectionResult::string );

PYTHON_COMPONENTS_COLOCATION( Section, Section );

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

        PYTHON_COMPONENTS_COLOCATION( Section, Section );
        ^
Additional context

bindings/python/src/inspector/colocation/component_meshes_colocation.h:33: expanded from macro 'PYTHON_COMPONENTS_COLOCATION'

        .def( pybind11::init< const type& >() )                                \
                              ^

.def_readwrite( "colocated_points_groups",
&MeshesColocationInspectionResult::colocated_points_groups )
.def( "string", &MeshesColocationInspectionResult::string );

PYTHON_COMPONENTS_COLOCATION( Section, Section );

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: unexpected type name 'SectionComponentMeshesColocation': expected expression [clang-diagnostic-error]

        PYTHON_COMPONENTS_COLOCATION( Section, Section );
        ^

expanded from here

@francoisbonneau francoisbonneau merged commit 8e6995e into refactor_all_inspector_api Dec 15, 2023
48 checks passed
@francoisbonneau francoisbonneau deleted the feat_meshes_inspector branch December 15, 2023 18:29
@BotellaA
Copy link
Member

🎉 This PR is included in version 5.0.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants