Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename anullus to annulus #666

Merged

Conversation

MFraters
Copy link
Member

resolves #539

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.64%. Comparing base (d6df754) to head (c6db3a8).
Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   92.85%   93.64%   +0.79%     
==========================================
  Files         105      106       +1     
  Lines        7176     7222      +46     
==========================================
+ Hits         6663     6763     +100     
+ Misses        513      459      -54     
Files Coverage Δ
source/gwb-grid/main.cc 54.72% <100.00%> (+8.26%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6df754...c6db3a8. Read the comment docs.

Copy link

github-actions bot commented Feb 22, 2024

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.020 ± 0.003 (s=430) 1.014 ± 0.004 (s=457) -0.7% .. -0.6%
Slab interpolation curved simple none 1.017 ± 0.004 (s=425) 1.017 ± 0.005 (s=463) -0.1% .. +0.1%
Spherical slab interpolation simple none 1.173 ± 0.006 (s=370) 1.172 ± 0.006 (s=400) -0.2% .. +0.1%
Slab interpolation simple curved CMS 1.061 ± 0.004 (s=444) 1.057 ± 0.004 (s=408) -0.4% .. -0.3%
Spherical slab interpolation simple CMS 1.551 ± 0.010 (s=276) 1.552 ± 0.009 (s=306) -0.1% .. +0.2%
Spherical fault interpolation simple none 1.175 ± 0.005 (s=363) 1.175 ± 0.006 (s=405) -0.2% .. +0.0%
Cartesian min max surface 2.299 ± 0.022 (s=180) 2.301 ± 0.034 (s=214) -0.4% .. +0.5%
Spherical min max surface 7.220 ± 0.094 (s=70) 7.215 ± 0.033 (s=57) -0.6% .. +0.5%

Copy link
Contributor

@jdannberg jdannberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also in sphinx/user_manual/how_to_use_the_applications/gwb-grid_app.md. That's where I found it.

@MFraters
Copy link
Member Author

ah, thanks! I did a search and replace all files in vs code, but I still had a filter for *.cc and *.h files, so that is why it didn't show up. I fixed it now.

@MFraters MFraters merged commit eed7e5d into GeodynamicWorldBuilder:main Feb 23, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename anullus to annulus?
2 participants