Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doi's for JOSS draft. #700

Merged
merged 1 commit into from Mar 14, 2024

Conversation

MFraters
Copy link
Member

Fixing issues on the bibtex found by the jossbot in openjournals/joss-reviews#6470.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (1f5fe62) to head (8d6e55c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #700      +/-   ##
==========================================
- Coverage   98.24%   98.23%   -0.02%     
==========================================
  Files         107      107              
  Lines        7464     7464              
==========================================
- Hits         7333     7332       -1     
- Misses        131      132       +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f5fe62...8d6e55c. Read the comment docs.

Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.021 ± 0.004 (s=433) 1.021 ± 0.006 (s=451) -0.1% .. +0.1%
Slab interpolation curved simple none 1.029 ± 0.005 (s=430) 1.023 ± 0.005 (s=450) -0.8% .. -0.5%
Spherical slab interpolation simple none 1.171 ± 0.005 (s=373) 1.171 ± 0.006 (s=398) -0.1% .. +0.1%
Slab interpolation simple curved CMS 1.064 ± 0.005 (s=408) 1.068 ± 0.004 (s=439) +0.2% .. +0.4%
Spherical slab interpolation simple CMS 1.556 ± 0.009 (s=288) 1.555 ± 0.010 (s=293) -0.2% .. +0.1%
Spherical fault interpolation simple none 1.236 ± 0.107 (s=364) 1.236 ± 0.107 (s=367) -2.1% .. +2.2%
Cartesian min max surface 2.311 ± 0.021 (s=184) 2.310 ± 0.022 (s=208) -0.3% .. +0.3%
Spherical min max surface 7.228 ± 0.038 (s=57) 7.220 ± 0.026 (s=70) -0.4% .. +0.2%

@MFraters MFraters merged commit 5039b7c into GeodynamicWorldBuilder:main Mar 14, 2024
34 of 37 checks passed
@MFraters MFraters mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant