Skip to content

Commit

Permalink
src: remove unnecessary else in base_object-inl.h
Browse files Browse the repository at this point in the history
This commit removes two unnecessary else statements in
base_object-inl.h. It also tries to make the if statements consistent
with regards to braces.

PR-URL: nodejs#33413
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
  • Loading branch information
danbev committed May 20, 2020
1 parent d2a6f06 commit 37b4717
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions src/base_object-inl.h
Expand Up @@ -217,20 +217,22 @@ BaseObject::PointerData*
BaseObjectPtrImpl<T, kIsWeak>::pointer_data() const {
if (kIsWeak) {
return data_.pointer_data;
} else {
if (get_base_object() == nullptr) return nullptr;
return get_base_object()->pointer_data();
}
if (get_base_object() == nullptr) {
return nullptr;
}
return get_base_object()->pointer_data();
}

template <typename T, bool kIsWeak>
BaseObject* BaseObjectPtrImpl<T, kIsWeak>::get_base_object() const {
if (kIsWeak) {
if (pointer_data() == nullptr) return nullptr;
if (pointer_data() == nullptr) {
return nullptr;
}
return pointer_data()->self;
} else {
return data_.target;
}
return data_.target;
}

template <typename T, bool kIsWeak>
Expand Down

0 comments on commit 37b4717

Please sign in to comment.