Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inefficient handling of burn in phase in sampling functions #180

Open
TolisChal opened this issue Oct 1, 2021 · 10 comments
Open

Inefficient handling of burn in phase in sampling functions #180

TolisChal opened this issue Oct 1, 2021 · 10 comments

Comments

@TolisChal
Copy link
Member

In header include/sampling.hpp the sampling functions do not handle the burn in phase efficiently.
They store the points of burn in phase and then they delete them.

RandomPointGenerator::apply(P, p, c, a, eta, nburns, walk_len, randPoints, push_back_policy, rng); randPoints.clear();

We need a new function to perform the burn in phase efficiently.

@purna135
Copy link

I would like to work on this issue

@Rajat1206
Copy link

I'd like to work on this issue if it's still open!

@nanu1605
Copy link

nanu1605 commented Mar 1, 2023

@TolisChal Is this still open? I would love to work on it

@vissarion
Copy link
Member

@nanu1605 please feel free to open a PR.

@hzratali
Copy link

@TolisChal Is this still open? I would love to work on it
Hey, are you working with this issue, if not then please assign me this issue. I would love to work on it.

@vissarion
Copy link
Member

@ha-rahman there are no assignments on issues, everyone is free to start working on a issue. The first pull request that is reviewed and approved will be merged.

@hzratali
Copy link

hzratali commented Mar 13, 2023 via email

@KhushV25
Copy link

hey , can i work on this?

@vissarion
Copy link
Member

@KhushV25 sure, please go ahead and submit a PR.

@nick2432
Copy link

can i submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants