-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake instructions for downloading Eigen #131
Conversation
Looks cool, thanks! For which versions of eigen is this working? It seems that circleci tests are failing. |
Nice PR, thanks! |
@vissarion It is working with the latest stable release of Eigen, i.e 3.3.9. |
@vissarion CircleCI test is still failing because of the CMake version, can we add instructions to build the latest version in CircleCI rather than installing it from apt-get? |
I updated the circleci script, let's see if this fixes your problem (you have to merge with current develop). Otherwise, feel free to propose a change in the circleci script (inside this PR) that make the tests passing. |
Yup, the circleci test is passing now, I hope this can be merged now 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, I got an idea for lpsolve library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's fine
For #114