Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake instructions for downloading Eigen #131

Merged
merged 3 commits into from
Feb 19, 2021

Conversation

vaithak
Copy link
Collaborator

@vaithak vaithak commented Feb 10, 2021

For #114

@vissarion
Copy link
Member

Looks cool, thanks!

For which versions of eigen is this working? It seems that circleci tests are failing.

@TolisChal
Copy link
Member

Nice PR, thanks!

@vaithak
Copy link
Collaborator Author

vaithak commented Feb 11, 2021

@vissarion It is working with the latest stable release of Eigen, i.e 3.3.9.
I checked the details of CircleCI build failure, the reason is that the FetchContent module of CMake is available in version >= 3.11, and the CMake version used in CircleCI is 3.7.2.
I have updated the CMakeLists.txt to require a minimum version of 3.11.
Is it possible to update the CMake on CircleCI?

@vaithak
Copy link
Collaborator Author

vaithak commented Feb 19, 2021

@vissarion CircleCI test is still failing because of the CMake version, can we add instructions to build the latest version in CircleCI rather than installing it from apt-get?

@vissarion
Copy link
Member

@vissarion CircleCI test is still failing because of the CMake version, can we add instructions to build the latest version in CircleCI rather than installing it from apt-get?

I updated the circleci script, let's see if this fixes your problem (you have to merge with current develop). Otherwise, feel free to propose a change in the circleci script (inside this PR) that make the tests passing.

@vaithak
Copy link
Collaborator Author

vaithak commented Feb 19, 2021

@vissarion CircleCI test is still failing because of the CMake version, can we add instructions to build the latest version in CircleCI rather than installing it from apt-get?

I updated the circleci script, let's see if this fixes your problem (you have to merge with current develop). Otherwise, feel free to propose a change in the circleci script (inside this PR) that make the tests passing.

Yup, the circleci test is passing now, I hope this can be merged now 😅

@vissarion vissarion merged commit ef93614 into GeomScale:develop Feb 19, 2021
@vissarion vissarion linked an issue Mar 4, 2021 that may be closed by this pull request
Copy link

@pradeexsu pradeexsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I got an idea for lpsolve library

Copy link

@pradeexsu pradeexsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove eigen external libraries
4 participants