Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic c++ documentation addition #253

Merged

Conversation

AlexManochis
Copy link
Contributor

This PR contributes C++ documentation tools and content

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #253 (376d7f8) into develop (fbc4206) will increase coverage by 0.08%.
The diff coverage is 52.63%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #253      +/-   ##
===========================================
+ Coverage    53.88%   53.96%   +0.08%     
===========================================
  Files          105      105              
  Lines         6169     6167       -2     
  Branches      2872     2874       +2     
===========================================
+ Hits          3324     3328       +4     
+ Misses         972      965       -7     
- Partials      1873     1874       +1     
Impacted Files Coverage Δ
include/cartesian_geom/point.h 62.00% <ø> (ø)
include/convex_bodies/ball.h 65.62% <0.00%> (ø)
include/convex_bodies/ballintersectconvex.h 88.88% <ø> (ø)
include/convex_bodies/convex_body.h 0.00% <ø> (ø)
...onvex_bodies/correlation_matrices/corre_matrix.hpp 69.04% <ø> (ø)
...correlation_matrices/correlation_spectrahedron.hpp 66.23% <ø> (ø)
...relation_matrices/correlation_spectrahedron_MT.hpp 50.00% <ø> (ø)
include/convex_bodies/hpolytope.h 75.82% <ø> (ø)
include/convex_bodies/orderpolytope.h 65.13% <ø> (ø)
include/convex_bodies/spectrahedra/spectrahedron.h 8.33% <ø> (ø)
... and 29 more

Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@elias-tsigaridas elias-tsigaridas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok to me.

@TolisChal
Copy link
Member

Thank you for this really useful PR! Good work!

@vissarion vissarion merged commit 82d1383 into GeomScale:develop Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants