Remove volesti4dingo branch #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfisikop
force-pushed
the
remove_volesti4dingo
branch
from
f2ba8f5
to
1ee9073
Compare
…ce parameter, add define lp_solve guards to orderpolytope
vfisikop
force-pushed
the
remove_volesti4dingo
branch
from
1ee9073
to
1ae6a45
Compare
TolisChal
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR that helps in removing the volesti4dingo branch used by dingo python package.
The main issue is lp_solve which is not used by dingo, hence we use the define flag DISABLE_LPSOLVE.
That could be changed in the future e.g. by removing lp_solve as a dependency.
This PR should fix #284