Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Light image viewer #397

Closed
bertob opened this issue Jul 19, 2023 · 1 comment · Fixed by #398
Closed

[Bug]: Light image viewer #397

bertob opened this issue Jul 19, 2023 · 1 comment · Fixed by #398
Labels
bug Something isn't working

Comments

@bertob
Copy link
Contributor

bertob commented Jul 19, 2023

Describe the bug

When opening an image the image viewer is no longer dark, which is not in line with the HIG.

It seems that this was motivated because the floating buttons were not visible enough (?), but it's definitely not a good solution. For an app like this keyboard shortcuts / Ctrl + scroll / pinch to zoom would probably be enough to be able to just drop the explicit zoom buttons.

Steps To Reproduce

  1. Open an image in the timeline

Logs and/or Screenshots

image

Instance Backend

Mastodon

Operating System

Fedora 38

Package

Flatpak

Troubleshooting information

os: GNOME 44 (Flatpak runtime)
prefix: /app
flatpak: true
version: 0.4.0 (production)
gtk: 4.10.3 (4.10.3)
libadwaita: 1.3.2 (1.3.2)
libsoup: 3.4.2 (3.4.2)
libgtksourceview: 5.8.0 (5.8.0)

Additional Context

No response

@bertob bertob added the bug Something isn't working label Jul 19, 2023
@GeopJr
Copy link
Owner

GeopJr commented Jul 20, 2023

Sounds good to me!

However, that issue will probably come up again for the pagination buttons, should they also be removed? (pagination also works with the arrow keys and the carousel gestures)

note to self: add Ctrl+, Ctrl- & Ctrl + mouse wheel shortcuts

GeopJr added a commit that referenced this issue Aug 4, 2023
GeopJr added a commit that referenced this issue Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants