fix(Status): name label styling #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
GeopJr
commented
Jul 2, 2023
•
GeopJr
commented
- headings (x boosted / favourited / etc) were some pixels to the right (button + padding + box spacing) but now should match the name label, label being in the same column as the status content
- name labels with emojis were some pixels higher than the handle due to the emoji. Fixing it is a bit hacky but it works: increase line height to 1.8 and negative padding vertically to decrease the size of the button
…/name-label-styling
|
:/ when the name wraps the line height is too much, maybe lowering the emoji pixel size? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.