fix(LWW): do not ellipsize when lines && widgets > 100 #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed in favor of #644 for now |
GeopJr
deleted the
fix/lww/do-not-ellipsize-when-lines-and-widget-are-over-100
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: without setting lines to 100 and ellipsizing, LLW would mess up its sizing. I do not think this is a problem anymore, maybe, but without ellipsizing theres a performance impact so it has to stay for now until the switch to ListView or other optimized containers. However, it seems that when a post contains only custom emojis, it needs ellipsizing to be off for the wrapping to be done right (ex. https://eepy.moe/notes/9li57c0uugndgjq2)
Solution: when lines and widgets > 100, set ellipsizing to none 🤷