Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filters #800

Merged
merged 9 commits into from
Feb 28, 2024
Merged

feat: filters #800

merged 9 commits into from
Feb 28, 2024

Conversation

GeopJr
Copy link
Owner

@GeopJr GeopJr commented Feb 24, 2024

fix: #200

Filter settings should be split into a separate FR I'll do it here ig

There's stuff I'm unsure about and stuff I'd rather hadn't added:

  • When a filter is set to hide completely, do we have to handle it at all? Shouldn't the server already handle that???
  • When multiple filters apply to a single post, do we show all filter titles or only the first one?
  • I'd rather we didn't have to use yet another stack. The status widgets are getting more and more bloated. There's now boxes in boxes in boxes in stacks in boxes and buttons and labels and flowboxes... it's getting ridiculous. Oh well 馃し
Screencast.from.2024-02-24.16-59-18.webm

@GeopJr GeopJr changed the title Feat/timeline/ignore filtered completely posts feat(timeline): ignore filtered completely posts Feb 24, 2024
@GeopJr GeopJr mentioned this pull request Feb 24, 2024
4 tasks
@GeopJr GeopJr changed the title feat(timeline): ignore filtered completely posts feat: filters Feb 24, 2024
@GeopJr GeopJr marked this pull request as draft February 24, 2024 20:01
@GeopJr
Copy link
Owner Author

GeopJr commented Feb 24, 2024

I'll do the settings on this PR too I guess

鈿狅笍 Tuba will only support v2 filters. Don't worry, if your backend errors during the initial call, the page won't be visible. 鈿狅笍

TODO:

  • Language filters
  • Edit page
  • Deletions
  • Saving
  • Filter icon
  • Fix casting with hide completely posts (esp. from notifications and convos timelines)
  • Finish filter design, at least the initial one

I'm not sure about the layout :/ maybe the expander rows are a bit too much? (they still need padding ofc). Also I doubt there are keyword limits on all backends so I set it to only expand if there are at most 10 keywords. The edit dialog would still need to display all of them.

Screencast.from.2024-02-24.22-45-53.webm

@GeopJr
Copy link
Owner Author

GeopJr commented Feb 25, 2024

Still so much to do but somewhat getting there. Not so fun fact, there are 0 limits on filters as far as I can tell. No keyword amount limit, not keyword length limit, no filter limit, no title length limit... 馃し

Screencast.from.2024-02-25.23-33-26.webm

@GeopJr GeopJr marked this pull request as ready for review February 28, 2024 21:48
@GeopJr GeopJr merged commit 6d93eef into main Feb 28, 2024
6 checks passed
@GeopJr GeopJr deleted the feat/timeline/ignore-filtered-completely-posts branch February 28, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: filters
1 participant