Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Admin Dashboard #959

Merged
merged 25 commits into from
Jun 9, 2024
Merged

feat: Admin Dashboard #959

merged 25 commits into from
Jun 9, 2024

Conversation

GeopJr
Copy link
Owner

@GeopJr GeopJr commented May 28, 2024

This is going to take ages to finish because setting up a mastodon instance is extremely annoying.

Needs ~16 ~4-5 pages

A lot to do but organized most of it so we can move forward to implementing the endpoints

GeopJr added 25 commits May 29, 2024 00:48
this will be used for requesting the admin perms. Also since it's not proxy only now, show the button even when there are other accounts
from our side, we need to know if we should even bother with dealing with the dash plus for permissions
that way if mastodon allows toggling in the future or administrator is disabled but others arent, it will still request those
…that match perms, load dash items in order instead of whatever arrives first

fix: date range

it's -29 apparently 🤷
@GeopJr GeopJr marked this pull request as ready for review June 9, 2024 10:02
@GeopJr
Copy link
Owner Author

GeopJr commented Jun 9, 2024

Finally! I'm free of this curse!

@GeopJr GeopJr merged commit 0b5b329 into main Jun 9, 2024
5 checks passed
@GeopJr GeopJr deleted the feat/admin-dashboard branch June 9, 2024 10:14
try {
status.formal.filtered = null;
status.formal.spoiler_text = null;
Widgets.Status widget = (Widgets.Status) status.to_widget ();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In report UI's, do make sure to blur & greyscale media displayed to the user (ideally with toggles off for each independently), to avoid display harmful content directly to moderators

(mastodon's moderator tools currently only blur reusing the sensitive media mode, instead of also have greyscaling)

Looks like it took a heap of work to implement this; if there's APIs or things you'd need from the mastodon side for admin do let me know

Copy link
Owner Author

@GeopJr GeopJr Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll move that to another issue so I can keep track of it.

if there's APIs or things you'd need from the mastodon side for admin do let me know

I'm not an instance admin (also why I didn't think of or notice the blur and greyscale features) so I really don't know what instance admins would need from a native client either. As can be seen by the edit on the pr body, I went in this with the thought that I would be implementing all admin and mod sections, only to discover that most are not accessible by the api (everything under administration, invites...). I'm not sure if that's something an admin would want to do outside of mastodon-web (and tbh I'd rather Tuba wasn't responsible for any of these :))

Again, I really don't know if these are something admins would want, but some of the stuff I remember not being able to do through the API:

  • Memoriam
  • Change user email
  • Change user password
  • Audit logs
  • Notes
  • Add/remove posts from a report
  • Deleting all reported posts (i think?)

I found a bug while implementing updating reports, where if there are rule violations with selected rules, you cannot change category. Mastodon-web will show it as if it was changed, but api-wise it hasn't:

Screencast.from.2024-06-24.05-54-33.webm

I was running a some-versions-behind instance when testing so I don't know if it has been fixed on master. From Tuba's side, I work around that by removing the rules before changing the category

Copy link

@ThisIsMissEm ThisIsMissEm Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to maybe just be an awkward API without good validation for report category change, as that's the way Mastodon's own UI does it too: https://github.com/mastodon/mastodon/blob/main/app/javascript/mastodon/components/admin/ReportReasonSelector.jsx#L127

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these might be most likely to be able to be added to the API:

  • Audit logs
  • Notes (assuming Account Notes and Report Notes)
  • Add/remove posts from a report

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah looks like the fix is still in master mastodon/mastodon@9ce914c

Thanks for taking a look!

I think these might be most likely to be able to be added to the API

Sounds good to me!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if that's something an admin would want to do outside of mastodon-web (and tbh I'd rather Tuba wasn't responsible for any of these :))

I'd agree tbh, as it is, I'm surprised you've implemented so much. Building good administrative and moderator UIs can be challenging because the needs are often very different to those of regular users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants