Pre-cache directive partials #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbrunner Note how I use |
elemoine
force-pushed
the
elemoine_partialcache
branch
from
1c89b34
to
63c8a8f
Compare
Merged
Closed
elemoine
force-pushed
the
elemoine_partialcache
branch
from
63c8a8f
to
6edeca2
Compare
|
I just rebased this. Please review. |
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the directive partials are downloaded by Angular with XHR requests at application init time, in both debug and non-debug mode. With this PR the directive partials are added to
build.js, thereby avoiding extra requests in non-debug mode. The behavior is unchanged in debug mode: directive partials are still downloaded at application init time.Please review.
Fixes #176.