Implement slicing #47
Conversation
| slice.numMsgs = 0; | ||
|
|
||
| % Loop through the LogMsgGroups, slicing each one | ||
| for msgGroup = slice.logMsgGroups |
There was a problem hiding this comment.
I don't understand the utility of the new logMsgGroups property. It seems to hold all the discovered message types as sub-properties, but apart from that I don't see anything else.
Especially since all the actual LogMsgGroups objects are properties of the Ardupilot object, not the Ardupilot.logMsgGroups property.
There was a problem hiding this comment.
For copying, I think we need some way to loop through all the LogMsgGroups in an Ardupilog and copy each.
One way to do it is keep the meta.DynamicProperty objects created during the "addprop()" call.
Another way I can think of, which I think you utilized in #50 is to loop through all properties and query each with isa(property, 'LogMsgGroup') before proceeding.
Do you prefer the 2nd way, or perhaps another way I haven't written here? I don't have a preference.
There was a problem hiding this comment.
I'd prefer to avoid creating another global property when a local approach is possible.
But I don't want to make you jump through hoops.
I'll merge this now and add an issue for me to change this eventually with the 'isa()' approach you suggested.
|
|
||
| end | ||
| methods(Access=protected) | ||
| function cpObj = copyElement(obj) |
There was a problem hiding this comment.
Matlab does, in general, a poor job of copying objects. Maybe you will like this as a better implementation of a deep copy.
There was a problem hiding this comment.
It looks very clean. Where do the component functions come from?
Would you prefer to use this implementation instead? I don't have a preference
There was a problem hiding this comment.
I think they're native. I don't have them installed separately.
Sorry for merging this too soon. We'll make the changes later.
This is a first attempt at slicing for LogMsgGroups as well as Ardupilogs. (NOTE: If we accept the re-organization from PR #46 , this one merges well with that too)
I made a number of initial decisions we could reconsider... such as:
No doubt as we do more slicing and better understand our needs, we might re-factor or even re-define how this works.