Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to customize the formatting of placeholders #89

Closed
GeorgH93 opened this issue Aug 19, 2019 · 2 comments
Closed

Add option to customize the formatting of placeholders #89

GeorgH93 opened this issue Aug 19, 2019 · 2 comments
Assignees
@GeorgH93
Labels
enhancement
Milestone
V2.1 Release

Comments

@GeorgH93
Copy link
Owner

Description:

An option that allows to control the format in which placeholders are resolved.
For example it would be useful if the %marriagemaster_heart% placeholder could be configured to return a space before/after the heart.
@GeorgH93 GeorgH93 self-assigned this Aug 19, 2019
@GeorgH93 GeorgH93 mentioned this issue Aug 19, 2019
Closed
@GeorgH93 GeorgH93 added this to the V2.1 Release milestone Aug 29, 2019
GeorgH93 added a commit that referenced this issue Aug 31, 2019
@GeorgH93
Improve placeholders, this starts implementation of #89
50466b3 
Make the config a bit simpler
Define the default not married values for all the heart and prefix/suffix placeholders to empty string
Allow all boolean placeholders to overwrite the True and False definitions separately
Load the values for all static placeholders (these that always show the same value if a player is married) from the language file
Fix home placeholders showing null/empty string if the player is not married
Fix home placeholders showing not married if no home is set (now uses NoHome value from language file)
Add an option to set the separator (PartnerList and PartnerDisplayNameList) for list placeholders
@GeorgH93
Copy link
Owner Author

With this build it is not possible to adjust almost every aspect of the placeholders.
The only thing missing is custom formatting for data placeholders (like partner name or home location). I don't know when I will add this, but the most important part is done now.

@GeorgH93
Copy link
Owner Author

GeorgH93 commented Sep 2, 2019

With this build all placeholders are fully customizable.
Documentation will be added to the placeholder wiki page once the v2.1 update releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeorgH93 GeorgH93

Labels
enhancement
Projects
None yet
Milestone
V2.1 Release
Development

No branches or pull requests
1 participant
@GeorgH93