Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add real version number to C64Studio.exe's Properties|Details tab for Windows Explorer #14

Conversation

keyworq
Copy link
Contributor

@keyworq keyworq commented Feb 2, 2019

Keeps version in sync with StudioCore string. (And refreshed the Copyright year.)

This pull-request is also a test for upstream issue #11 - "No email notifications on Pull requests"

…xplorer

Keeps version in sync with StudioCore string. (And refreshed the Copyright year.)

The upcoming pull-request is also a test for upstream issue # 11 - "No email notifications on Pull requests"
  GeorgRottensteiner#11
@GeorgRottensteiner
Copy link
Owner

Hi,
I appreciate the real version number patch. The problem is the settings are fetched from a folder with the version name in its name. Whenever someone updates the executable, the version changes, and the previous settings file is not found any more. That's why I didn't use proper version numbering (yet). I'm aware I should do that, but before doing that I have to add some code to be able to use older settings if they exist.
Nobody likes their settings being reset ;)

I've just added a change so I can use proper numbering. Will pull!

@GeorgRottensteiner GeorgRottensteiner merged commit d1c5dce into GeorgRottensteiner:master Feb 2, 2019
@keyworq keyworq deleted the feature-exe-props-tab-version branch February 2, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants