Question: Add exists_all/exists_any for jsonb/hstore columns #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elcuervo
commented
Jun 17, 2022
| if [:hstore, :jsonb].include?(column.type) | ||
| kind.new(arel.left, arel.right) | ||
| else | ||
| raise ArgumentError.new("Invalid argument for .where.#{kind}(), got #{arel.class}") |
There was a problem hiding this comment.
This is not user friendly (kind is a ruby class) but just leaving it here.
If the feature makes sense some cleanup and documentation should be added as well :)
|
@elcuervo Hey sorry for the radio silence. I've been sitting on this for a while and wanted to first get out my autoloader changes before spearheading into new functionality. Now that it has been pushed out if you could realign your branch I can take a fresh look into this addition 👍 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements some other operations from https://www.postgresql.org/docs/9.4/functions-json.html#FUNCTIONS-JSONB-OP-TABLE
First of all thank you for your work on the gem.
We use it extensively and it's fantastic.
From time to time I want to check if a jsonb column has a given set of keys (we use some of them to
enable and disable features)
This is just an initial idea. The AREL build is far from elegant but I wanted to get your feedback
about the concept.
My AREL-fu is not too strong so feel free to correct anything that looks weird.